Skip to content

fix: relax validation of unsafe configuration to allow an empty object#7461

Merged
penalosa merged 1 commit intomainfrom
pbd/relax-unsafe-config-validation
Dec 5, 2024
Merged

fix: relax validation of unsafe configuration to allow an empty object#7461
penalosa merged 1 commit intomainfrom
pbd/relax-unsafe-config-validation

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

The types, the default and the code in general support an empty object for this config setting.

So it makes sense to avoid erroring when validating the config.

Fixes #0000


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: just a minor change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no docs change needed

@petebacondarwin petebacondarwin requested a review from a team as a code owner December 5, 2024 17:19
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 3480cf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The types, the default and the code in general support an empty object for this config setting.

So it makes sense to avoid erroring when validating the config.
@petebacondarwin petebacondarwin force-pushed the pbd/relax-unsafe-config-validation branch from 28379b2 to 3480cf4 Compare December 5, 2024 17:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-wrangler-7461

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7461/npm-package-wrangler-7461

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-wrangler-7461 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-create-cloudflare-7461 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-kv-asset-handler-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-miniflare-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-pages-shared-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-vitest-pool-workers-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-workers-editor-shared-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-workers-shared-7461
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12184774062/npm-package-cloudflare-workflows-shared-7461

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 9ede45b into main Dec 5, 2024
@penalosa penalosa deleted the pbd/relax-unsafe-config-validation branch December 5, 2024 18:45
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants