Remove defaults for batch-max-* pipeline parameters and define value ranges#7576
Conversation
🦋 Changeset detectedLatest commit: 65b67ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-wrangler-7576You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7576/npm-package-wrangler-7576Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-wrangler-7576 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-bindings-extension-7576 -O ./cloudflare-workers-bindings-extension.0.0.0-vfe8b3a722.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfe8b3a722.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-create-cloudflare-7576 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-kv-asset-handler-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-miniflare-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-pages-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-unenv-preset-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-vitest-pool-workers-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-editor-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workers-shared-7576npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677414917/npm-package-cloudflare-workflows-shared-7576Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
I see that we mentioned the default value in the description already. Is this the same default value we have on the API side? That's why this is a non-breaking change?
There was a problem hiding this comment.
Yeah, 10 MB is the current default on the API side. Regarding breaking changes, this is currently in private beta and changes like this are expected.
There was a problem hiding this comment.
The defaults are still being determined, so I removed here and will instead only set them on the API side.
cmackenzie1
force-pushed
the
cole/pipe-152-batch-min-max
branch
2 times, most recently
from
fa11ba7 to
0a33de4
Compare
Closes https://jira.cfdata.org/browse/PIPE-152 The defaults are currently in flux and changing as we determine what makes sense for the system. To support these changing values, remove the defaults from the client as they will be set by the API. The values used to create the pipeline are visible to user when doing `wrangler pipeline show <name>`. Create three-chefs-bathe.md
cmackenzie1
force-pushed
the
cole/pipe-152-batch-min-max
branch
from
0a33de4 to
ea966a8
Compare
cmackenzie1
force-pushed
the
cole/pipe-152-batch-min-max
branch
from
ea966a8 to
65b67ce
Compare
cmackenzie1
changed the title
batch-max-* pipeline parametersbatch-max-* pipeline parameters and define value ranges
3 participants
Closes https://jira.cfdata.org/browse/PIPE-152
Describe your change...