Skip to content

test(wrangler): allow overriding the unenv preset#7685

Merged
vicb merged 2 commits intomainfrom
resolution/path
Jan 7, 2025
Merged

test(wrangler): allow overriding the unenv preset#7685
vicb merged 2 commits intomainfrom
resolution/path

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jan 7, 2025

Reapply of #7522

The initial PR was reverted by #7583

The root caused was fixed in #7614 (via unjs/unenv#378)

/cc @pi0


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tested locally, will be tested in a follow up PR (needs a release of unenv-preset)
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner January 7, 2025 09:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 4437ed6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-wrangler-7685

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7685/npm-package-wrangler-7685

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-wrangler-7685 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-workers-bindings-extension-7685 -O ./cloudflare-workers-bindings-extension.0.0.0-vdc1821815.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vdc1821815.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-create-cloudflare-7685 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-kv-asset-handler-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-miniflare-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-pages-shared-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-unenv-preset-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-vitest-pool-workers-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-workers-editor-shared-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-workers-shared-7685
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12656365645/npm-package-cloudflare-workflows-shared-7685

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb requested a review from petebacondarwin January 7, 2025 11:31
Comment thread .changeset/twelve-fireants-hunt.md Outdated
vicb and others added 2 commits January 7, 2025 18:36
@vicb vicb force-pushed the resolution/path branch from da61163 to 4437ed6 Compare January 7, 2025 17:36
@vicb vicb changed the title feat(wrangler): allow overriding the unenv preset test(wrangler): allow overriding the unenv preset Jan 7, 2025
@vicb vicb merged commit 9d2740a into main Jan 7, 2025
@vicb vicb deleted the resolution/path branch January 7, 2025 19:15
@workers-devprod workers-devprod mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants