Fix D1 exports to properly pad HEX strings for binary values#7701
Merged
lambrospetrou merged 2 commits intomainfrom Jan 9, 2025
Merged
Fix D1 exports to properly pad HEX strings for binary values#7701lambrospetrou merged 2 commits intomainfrom
lambrospetrou merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 169c8fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-wrangler-7701You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7701/npm-package-wrangler-7701Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-wrangler-7701 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-workers-bindings-extension-7701 -O ./cloudflare-workers-bindings-extension.0.0.0-vedc0f7a84.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vedc0f7a84.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-create-cloudflare-7701 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-kv-asset-handler-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-miniflare-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-pages-shared-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-unenv-preset-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-vitest-pool-workers-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-workers-editor-shared-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-workers-shared-7701npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12688317519/npm-package-cloudflare-workflows-shared-7701Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
rozenmd
approved these changes
Jan 8, 2025
penalosa
approved these changes
Jan 8, 2025
364e740 to
3c50744
Compare
The export logic was corrupting data when a binary value was being converted into HEX strings, and one of the bytes had a leading zero. Closes #6452
3c50744 to
169c8fd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6452
The export logic was corrupting data when a binary value was being converted into HEX strings, and one of the bytes had a leading zero.
Also fixed in the internal version used in production (CFSQL-1166).