feat: pull resource names for provisioning from config if provided #7733
feat: pull resource names for provisioning from config if provided #7733emily-shen merged 9 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 918dd54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
tangential, but noticed that d1 list pagination seems to default to 10 per page, which seems quite low to me - is there a particular reason this is the case? KV is 100 per page for reference
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-wrangler-7733You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7733/npm-package-wrangler-7733Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-wrangler-7733 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-workers-bindings-extension-7733 -O ./cloudflare-workers-bindings-extension.0.0.0-v6b12484ed.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v6b12484ed.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-create-cloudflare-7733 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-kv-asset-handler-7733miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-miniflare-7733@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-pages-shared-7733@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-unenv-preset-7733@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-vitest-pool-workers-7733@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-workers-editor-shared-7733@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-workers-shared-7733@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12773009455/npm-package-cloudflare-workflows-shared-7733Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
b1fab1b to
758fae3
Compare
penalosa
left a comment
There was a problem hiding this comment.
Couple comments, but in general lgtm
| const foundResourceId = preExisting.find( | ||
| (r) => r.title === name | ||
| )?.value; |
There was a problem hiding this comment.
What case is this catering for? Surely if the item has a name (D1 or R2) which maps to an existing resource we should have already bound to it further up? Why do we need to ask the user?
There was a problem hiding this comment.
added a comment to explain.
Decided to keep searching preExisting for now since it is unlikely normal users will hit this, but will follow up to ask for a getD1ByName endpoint.
Fixes DEVX-1556