Skip to content

Unwrap SDW errors before sending to Sentry#7735

Merged
penalosa merged 5 commits intomainfrom
penalosa/sentry-fixup
Jan 15, 2025
Merged

Unwrap SDW errors before sending to Sentry#7735
penalosa merged 5 commits intomainfrom
penalosa/sentry-fixup

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

This should make Sentry errors more actionable, by unwrapping error cause (which was causing all the captureGlobalException issues)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: some existing tests cover sentry, and this isn't really testable
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@penalosa penalosa requested a review from a team as a code owner January 10, 2025 21:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: f3737b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-wrangler-7735

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7735/npm-package-wrangler-7735

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-wrangler-7735 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-workers-bindings-extension-7735 -O ./cloudflare-workers-bindings-extension.0.0.0-v140dad216.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v140dad216.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-create-cloudflare-7735 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-kv-asset-handler-7735

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-miniflare-7735

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-pages-shared-7735

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-unenv-preset-7735

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-vitest-pool-workers-7735

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-workers-editor-shared-7735

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-workers-shared-7735

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12772991164/npm-package-cloudflare-workflows-shared-7735

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.101.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Comment thread packages/wrangler/src/index.ts Outdated
Comment thread .changeset/honest-spies-prove.md Outdated
penalosa and others added 3 commits January 13, 2025 19:41
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
@penalosa penalosa merged commit e8aaa39 into main Jan 15, 2025
@penalosa penalosa deleted the penalosa/sentry-fixup branch January 15, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants