Migrate vite-plugin-cloudflare to workers-sdk by petebacondarwin · Pull Request #7763 · cloudflare/workers-sdk

petebacondarwin · 2025-01-14T16:02:49Z

Brings the vite-plugin-cloudflare package into workers-sdk

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: e2e tests are not related to this code
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: docs are included in the README of the package for now

changeset-bot · 2025-01-14T16:02:53Z

🦋 Changeset detected

Latest commit: c9d2732

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-14T16:49:03Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-wrangler-7763

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7763/npm-package-wrangler-7763

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-wrangler-7763 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-workers-bindings-extension-7763 -O ./cloudflare-workers-bindings-extension.0.0.0-vd8e71f75c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd8e71f75c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-create-cloudflare-7763 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-kv-asset-handler-7763

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-miniflare-7763

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-pages-shared-7763

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-unenv-preset-7763

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-vite-plugin-7763

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-vitest-pool-workers-7763

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-workers-editor-shared-7763

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-workers-shared-7763

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12866144419/npm-package-cloudflare-workflows-shared-7763

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.103.2 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241230.2
`workerd`	1.20241230.0	1.20241230.0
`workerd --version`	1.20241230.0	2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

penalosa

I haven't reviewed vite-plugin-cloudflare since I assume it's already been reviewed in parts as it's developed, but everything else looks good other than a few comments

penalosa · 2025-01-16T00:00:35Z

It doesn't look like this team is public?

It is "visible"... not sure how to make it more public than that...

jamesopstad

Looks great! Just a few suggestions.

petebacondarwin

.

jamesopstad

I've added in some additional suggestions as there was a bit more time.

* packages/vite-plugin-cloudflare -> packages/vite-plugin-cloudflare * playground -> packages/vite-plugin-cloudflare/playground * vitest.config.e2e.ts -> packages/vite-plugin-cloudflare/playground/vitest.config.ts Co-authored-by: Peter Bacon Darwin <pete@bacondarwin.com> Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>

…NERS

This is probably not needed because any generated files are already gitignored

…ant to this PR

…tsconfig

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

petebacondarwin force-pushed the pbd/add-vite-plugin branch 6 times, most recently from f22eeec to dc11bc1 Compare January 15, 2025 21:32

petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 15, 2025

petebacondarwin force-pushed the pbd/add-vite-plugin branch from 1338cd6 to 078e608 Compare January 15, 2025 21:54

petebacondarwin added no-changeset-required and removed e2e Run wrangler + vite-plugin e2e tests on a PR labels Jan 15, 2025

petebacondarwin changed the title ~~WIP - testing the migration of vite-plugin-cloudflare to workers-sdk~~ Migrate vite-plugin-cloudflare to workers-sdk Jan 15, 2025

petebacondarwin marked this pull request as ready for review January 15, 2025 22:19

petebacondarwin requested a review from a team as a code owner January 15, 2025 22:19

petebacondarwin requested a review from a team January 15, 2025 22:19

penalosa approved these changes Jan 16, 2025

View reviewed changes

petebacondarwin removed the no-changeset-required label Jan 16, 2025

petebacondarwin force-pushed the pbd/add-vite-plugin branch 2 times, most recently from cd2a5a6 to a46e068 Compare January 16, 2025 11:40

petebacondarwin added no-changeset-required and removed no-changeset-required labels Jan 16, 2025

jamesopstad reviewed Jan 16, 2025

View reviewed changes

petebacondarwin commented Jan 16, 2025

View reviewed changes

petebacondarwin requested a review from jamesopstad January 16, 2025 14:13

petebacondarwin force-pushed the pbd/add-vite-plugin branch from a3bb0cd to 1143a5b Compare January 16, 2025 14:41

jamesopstad approved these changes Jan 16, 2025

View reviewed changes

jamesopstad reviewed Jan 19, 2025

View reviewed changes

jamesopstad and others added 2 commits January 20, 2025 10:23

update vite-plugin-cloudflare files to work with workers-sdk

86154bd

petebacondarwin and others added 17 commits January 20, 2025 10:24

add playground to CI tests

fb57d45

add frameworks team to unenv-preset and vite-plugin-cloudflare CODEOW…

f9e0ad2

…NERS

Rename @flarelabs-net/vite-plugin-cloudflare to @cloudflare/vite-plugin

1e719aa

Remove the use of playground-temp

8fc4018

This is probably not needed because any generated files are already gitignored

Remove unnecessary workers-types catalog entry

6cf8929

Add changeset

60ab59e

add Vite plugin beta releases off main

34956b8

Fix up package.json repo URL

e2a1d01

Add test script

091867f

Remove changes to vitest-pool-workers test config, which is not relev…

539d2ff

…ant to this PR

update CODEOWNERS so frameworks team can also see changes to workers-…

b31c31b

…tsconfig

Fix package-lock file

f4b954f

Fix up minimum Vite version for the Cloudflare Vite Plugin

5d756ee

Add README

1a436c8

Update packages/vite-plugin-cloudflare/package.json

220985d

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

Update packages/vite-plugin-cloudflare/package.json

99ed407

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

use Cloudflare environments terminology consistently in README

fdccaa2

petebacondarwin force-pushed the pbd/add-vite-plugin branch from fa781ea to fdccaa2 Compare January 20, 2025 10:25

Fix whitespace

c9d2732

CarmenPopoviciu merged commit 7e04493 into main Jan 20, 2025

CarmenPopoviciu deleted the pbd/add-vite-plugin branch January 20, 2025 10:55

workers-devprod mentioned this pull request Jan 20, 2025

Version Packages #7825

Merged

Conversation

petebacondarwin commented Jan 14, 2025 • edited by penalosa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

penalosa left a comment

Choose a reason for hiding this comment

Uh oh!

penalosa Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jamesopstad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

jamesopstad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

petebacondarwin commented Jan 14, 2025 •

edited by penalosa

Loading

changeset-bot Bot commented Jan 14, 2025 •

edited

Loading

github-actions Bot commented Jan 14, 2025 •

edited

Loading