Skip to content

Revert "chore(wrangler): use the unenv preset from @cloudflare/unenv-preset"#7797

Merged
CarmenPopoviciu merged 1 commit intomainfrom
revert-7720-use-cf-preset
Jan 16, 2025
Merged

Revert "chore(wrangler): use the unenv preset from @cloudflare/unenv-preset"#7797
CarmenPopoviciu merged 1 commit intomainfrom
revert-7720-use-cf-preset

Conversation

@CarmenPopoviciu
Copy link
Copy Markdown
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jan 16, 2025

Reverts #7720 as it introduced breakage in some of the C3 templates (eg. Nuxt)

How was this tested

  • create a Nuxt project via npm create cloudflare@latest (2.36.0 at the time of this writing)
  • change the wrangler version in the generated project's package.json to the wrangler pre-release version of this PR
  • npm i again
  • npm run preview - which previously failed
  • 🎉 👇
Screenshot 2025-01-16 at 17 14 07

Why was this not caught by our C3 e2e tests?

When our C3 e2e tests run, they (in a nutshell) build C3 out of the main branch, and create a starter project (via that previously built executable) for each framework under test. Once the starter project is created, certain assertions are made on it.

A starter project will come with a list of predefined dependencies, necessary for the project to run and be deployed, defined in package.json. All (I think) C3 starter projects will have a dependency on wrangler, specifically, on the latest released version of wrangler. This is crucial to note here, because while the e2e tests are running in the "context" of a wrangler built off of main (let's call this version N), they are in fact making assertions against starter projects that were built with wrangler version N-1 (wrangler@latest).

In our case this resulted in a false positive CI run, where C3 e2e tests were successful, when they should have instead failed

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner January 16, 2025 15:25
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: bd4875f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and Sorry!

@github-actions
Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-wrangler-7797

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7797/npm-package-wrangler-7797

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-wrangler-7797 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-bindings-extension-7797 -O ./cloudflare-workers-bindings-extension.0.0.0-vd3a379123.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd3a379123.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-create-cloudflare-7797 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-kv-asset-handler-7797

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-miniflare-7797

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-pages-shared-7797

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-unenv-preset-7797

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-vitest-pool-workers-7797

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-editor-shared-7797

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-shared-7797

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workflows-shared-7797

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.103.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu added the skip-pr-description-validation Skip validation of the required PR description format label Jan 16, 2025
@lrapoport-cf
Copy link
Copy Markdown
Contributor

@CarmenPopoviciu this is approved to merge despite c3 e2e tests failing. c3 tests will only be fixed by landing this change and releasing wrangler. see PR description for additional detail/context

@CarmenPopoviciu CarmenPopoviciu merged commit 7c1c90e into main Jan 16, 2025
@CarmenPopoviciu CarmenPopoviciu deleted the revert-7720-use-cf-preset branch January 16, 2025 17:13
This was referenced Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants