Revert "chore(wrangler): use the unenv preset from @cloudflare/unenv-preset"#7797
Revert "chore(wrangler): use the unenv preset from @cloudflare/unenv-preset"#7797CarmenPopoviciu merged 1 commit intomainfrom
@cloudflare/unenv-preset"#7797Conversation
…-preset`…" This reverts commit 902e3af.
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-wrangler-7797You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7797/npm-package-wrangler-7797Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-wrangler-7797 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-bindings-extension-7797 -O ./cloudflare-workers-bindings-extension.0.0.0-vd3a379123.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd3a379123.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-create-cloudflare-7797 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-kv-asset-handler-7797miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-miniflare-7797@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-pages-shared-7797@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-unenv-preset-7797@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-vitest-pool-workers-7797@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-editor-shared-7797@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workers-shared-7797@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12812100756/npm-package-cloudflare-workflows-shared-7797Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
@CarmenPopoviciu this is approved to merge despite c3 e2e tests failing. c3 tests will only be fixed by landing this change and releasing wrangler. see PR description for additional detail/context |
Reverts #7720 as it introduced breakage in some of the C3 templates (eg. Nuxt)
How was this tested
npm create cloudflare@latest(2.36.0at the time of this writing)package.jsonto the wrangler pre-release version of this PRnpm iagainnpm run preview- which previously failedWhy was this not caught by our C3 e2e tests?
When our C3 e2e tests run, they (in a nutshell) build C3 out of the
mainbranch, and create a starter project (via that previously built executable) for each framework under test. Once the starter project is created, certain assertions are made on it.A starter project will come with a list of predefined dependencies, necessary for the project to run and be deployed, defined in
package.json. All (I think) C3 starter projects will have a dependency onwrangler, specifically, on the latest released version of wrangler. This is crucial to note here, because while the e2e tests are running in the "context" of a wrangler built off ofmain(let's call this versionN), they are in fact making assertions against starter projects that were built with wrangler versionN-1(wrangler@latest).In our case this resulted in a false positive CI run, where C3 e2e tests were successful, when they should have instead failed