Skip to content

Fix asset-worker not logging analytics for successful requests#7808

Merged
WalshyDev merged 2 commits intomainfrom
walshy/fix-metrics
Jan 20, 2025
Merged

Fix asset-worker not logging analytics for successful requests#7808
WalshyDev merged 2 commits intomainfrom
walshy/fix-metrics

Conversation

@WalshyDev
Copy link
Copy Markdown
Member

@WalshyDev WalshyDev commented Jan 17, 2025

Fixes N/A

Fix analytics not being logged for asset-worker in the case of a successful request.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: analytics change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: analytics change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: analytics change

@WalshyDev WalshyDev requested review from a team as code owners January 17, 2025 12:42
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: b1e39b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-wrangler-7808

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7808/npm-package-wrangler-7808

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-wrangler-7808 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-workers-bindings-extension-7808 -O ./cloudflare-workers-bindings-extension.0.0.0-vc9060b010.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc9060b010.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-create-cloudflare-7808 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-kv-asset-handler-7808

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-miniflare-7808

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-pages-shared-7808

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-unenv-preset-7808

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-vitest-pool-workers-7808

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-workers-editor-shared-7808

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-workers-shared-7808

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12831625634/npm-package-cloudflare-workflows-shared-7808

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.103.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev merged commit 7faabeb into main Jan 20, 2025
@WalshyDev WalshyDev deleted the walshy/fix-metrics branch January 20, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants