Skip to content

fix(wrangler): fix schema defaults#7821

Merged
vicb merged 2 commits intomainfrom
schema
Jan 20, 2025
Merged

fix(wrangler): fix schema defaults#7821
vicb merged 2 commits intomainfrom
schema

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jan 20, 2025

Fixes #7820

Prior to this PR, the default for i.e. compatibility_flags was "`[]`" while it should be [] only. It made the autocomplete of wrangler.json and wrangler.toml in VSCode wrong (tested with the "Even Better TOML" extension)

On top of removing the backquotes, the PR also remove some comments that were not meant to be displayed.

Note that the formatting of the default value, i.e. {consumers:[],producers:[]} does not use the usual formatting because it breaks VSCode syntax highlithing.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner January 20, 2025 08:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 4754cd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from petebacondarwin January 20, 2025 08:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 20, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-wrangler-7821

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7821/npm-package-wrangler-7821

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-wrangler-7821 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-workers-bindings-extension-7821 -O ./cloudflare-workers-bindings-extension.0.0.0-v75c1bd3d0.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v75c1bd3d0.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-create-cloudflare-7821 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-kv-asset-handler-7821

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-miniflare-7821

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-pages-shared-7821

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-unenv-preset-7821

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-vite-plugin-7821

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-vitest-pool-workers-7821

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-workers-editor-shared-7821

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-workers-shared-7821

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12870494220/npm-package-cloudflare-workflows-shared-7821

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.103.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Comment thread packages/wrangler/src/config/environment.ts Outdated
Comment thread packages/wrangler/src/config/environment.ts Outdated
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jan 20, 2025

Thanks for the review @penalosa!

@vicb vicb merged commit fcaa02c into main Jan 20, 2025
@vicb vicb deleted the schema branch January 20, 2025 15:05
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jan 20, 2025

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: schema: wrangler.(json|toml) auto-completes wrong values

3 participants