fix(create-cloudflare): bump vitest-pool-workers version on the templates by edmundhung · Pull Request #7827 · cloudflare/workers-sdk

edmundhung · 2025-01-20T13:36:17Z

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: package version bump

changeset-bot · 2025-01-20T13:36:22Z

🦋 Changeset detected

Latest commit: 583d551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-20T13:39:23Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-wrangler-7827

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7827/npm-package-wrangler-7827

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-wrangler-7827 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-workers-bindings-extension-7827 -O ./cloudflare-workers-bindings-extension.0.0.0-v566bdc5be.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v566bdc5be.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-create-cloudflare-7827 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-kv-asset-handler-7827

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-miniflare-7827

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-pages-shared-7827

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-unenv-preset-7827

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-vite-plugin-7827

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-vitest-pool-workers-7827

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-workers-editor-shared-7827

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-workers-shared-7827

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12888773890/npm-package-cloudflare-workflows-shared-7827

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.103.2 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241230.2
`workerd`	1.20241230.0	1.20241230.0
`workerd --version`	1.20241230.0	2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

CarmenPopoviciu · 2025-01-20T17:29:55Z

this feels like something we should be doing for all C3 starter projects that come accompanied by tests?

Afaik only hello-world and the experimental hello-world-with-assets template (js/ts) includes some tests. But there is no e2e tests for non-framework experimental templates. Let me see if I can set it up for the assets template 👍🏼

Added tests for all non-framework experimental templates on 6865673 and c180e93

@edmundhung you are the abs best!!!! ♥️

CarmenPopoviciu · 2025-01-21T07:48:09Z

🥹 sooo prity 🫶

…ates

penalosa · 2025-01-21T13:49:11Z

I think this will probably break the e2e cleanup scripts—is there a reason this needed to be changed?

Good catch! That might explains why some e2e tests are failing 😅

We are using prefix + random suffix + template name + language as the project name on the e2e tests and some of the templates end up with a project name more than 58 chars. So I was thinking if we can shrink the prefix a bit to save a few chars.. but maybe I should just trim it.

Reverted in 583d551

edmundhung · 2025-01-21T14:46:52Z

@CarmenPopoviciu @penalosa This is ready for review again 👍🏼

edmundhung · 2025-01-21T14:51:33Z

 			{
 				template: "scheduled",
-				variants: ["TypeScript", "JavaScript"],
+				variants: ["ts", "js"],


All the variant name is changed as

It is now passed as --lang [lang] instead of going through a prompt and have the test script figure out the right answer.

They are part of the project name and might become too long depending on the template name. It should be less likly to be over 58 chars now.

edmundhung · 2025-01-21T14:53:01Z

-								promptHandlers: [
-									{
-										matcher: /Which language do you want to use\?/,
-										input: {
-											type: "select",
-											target: variant,
-										},
-									},
-								],


We are now passing the --lang arg directly instead of trying to answer the prompt.

edmundhung · 2025-01-21T14:54:40Z

-							const gitignorePath = join(project.path, ".gitignore");
-							expect(gitignorePath).toExist();
-


The asset-only template has no .gitignore. I could have add an options to skip this check but I think we shouldn't assume .gitignore exists on all template especially when the git setup on c3 is optional.

edmundhung · 2025-01-21T14:55:04Z

+								if (config.main) {
+									expect(join(project.path, config.main)).toExist();
+								}


The asset-only template has no main file 😅

edmundhung mentioned this pull request Jan 20, 2025

🐛 BUG: npm test fails on fresh hello world create cloudflare project #7815

Closed

edmundhung added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 20, 2025

edmundhung marked this pull request as ready for review January 20, 2025 17:16

edmundhung requested a review from a team as a code owner January 20, 2025 17:16

edmundhung requested a review from a team January 20, 2025 17:16

CarmenPopoviciu reviewed Jan 20, 2025

View reviewed changes

Comment thread packages/create-cloudflare/e2e-tests/workers.test.ts Outdated

CarmenPopoviciu reviewed Jan 20, 2025

View reviewed changes

Comment thread packages/create-cloudflare/e2e-tests/helpers.ts Outdated

CarmenPopoviciu reviewed Jan 20, 2025

View reviewed changes

edmundhung force-pushed the edmundhung/fix-vpw-version-on-c3-templates branch from f12136c to 6865673 Compare January 20, 2025 17:59

CarmenPopoviciu reviewed Jan 21, 2025

View reviewed changes

Comment thread packages/create-cloudflare/e2e-tests/helpers.ts Outdated

Copy link
Copy Markdown

Contributor

CarmenPopoviciu Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥹 sooo prity 🫶

edmundhung force-pushed the edmundhung/fix-vpw-version-on-c3-templates branch from 0739dc4 to 1d45ce9 Compare January 21, 2025 12:04

edmundhung added 11 commits January 21, 2025 13:49

fix(create-cloudflare): bump vitest-pool-workers version on the templ…

c6a01a6

…ates

chore: verify the test script on hello-world template

686c866

chore: fix hello-world-js test

4b7812b

chore: add description for runner config

2dc7bb6

chore: test non-framework experimental templates

d2a42f6

fixup! chore: test non-framework experimental templates

fed56bd

bootstraping projects with the experimental arg

887456b

do not skip experimental workers templates

4761a3b

experimental template does not infer category

49cda5b

project name can only be up to 58 chars

58b9af2

asset-only-template has no main file

d3e1866

edmundhung force-pushed the edmundhung/fix-vpw-version-on-c3-templates branch from 1d45ce9 to d3e1866 Compare January 21, 2025 13:49

penalosa reviewed Jan 21, 2025

View reviewed changes

make sure generated project name does not end with a dash

583d551

edmundhung commented Jan 21, 2025

View reviewed changes

andyjessop approved these changes Jan 21, 2025

View reviewed changes

andyjessop merged commit 6c2e943 into main Jan 21, 2025

andyjessop deleted the edmundhung/fix-vpw-version-on-c3-templates branch January 21, 2025 15:51

workers-devprod mentioned this pull request Jan 21, 2025

Version Packages #7825

Merged

		const gitignorePath = join(project.path, ".gitignore");
		expect(gitignorePath).toExist();

Conversation

edmundhung commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edmundhung commented Jan 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edmundhung Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

edmundhung commented Jan 20, 2025 •

edited

Loading

changeset-bot Bot commented Jan 20, 2025 •

edited

Loading

github-actions Bot commented Jan 20, 2025 •

edited

Loading

edmundhung Jan 21, 2025 •

edited

Loading