Skip to content

fix(wrangler): improve multi account error message in non-interactive mode#7828

Merged
edmundhung merged 3 commits intomainfrom
edmundhung/improve-get-account-error-message
Jan 20, 2025
Merged

fix(wrangler): improve multi account error message in non-interactive mode#7828
edmundhung merged 3 commits intomainfrom
edmundhung/improve-get-account-error-message

Conversation

@edmundhung
Copy link
Copy Markdown
Member

@edmundhung edmundhung commented Jan 20, 2025

Fixes #6466


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: error message update

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: a59864e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 20, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-wrangler-7828

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7828/npm-package-wrangler-7828

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-wrangler-7828 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-workers-bindings-extension-7828 -O ./cloudflare-workers-bindings-extension.0.0.0-v50fc9694e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v50fc9694e.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-create-cloudflare-7828 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-kv-asset-handler-7828

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-miniflare-7828

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-pages-shared-7828

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-unenv-preset-7828

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-vite-plugin-7828

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-vitest-pool-workers-7828

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-workers-editor-shared-7828

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-workers-shared-7828

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12871112509/npm-package-cloudflare-workflows-shared-7828

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.103.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 20, 2025
@edmundhung edmundhung marked this pull request as ready for review January 20, 2025 16:45
@edmundhung edmundhung requested review from a team as code owners January 20, 2025 16:45
@edmundhung edmundhung merged commit 9077a67 into main Jan 20, 2025
@edmundhung edmundhung deleted the edmundhung/improve-get-account-error-message branch January 20, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: Build Requests account_id in Wrangler.toml but fails with account_id

2 participants