Skip to content

Relax the messaging when Wrangler uses redirected configuration#7832

Merged
CarmenPopoviciu merged 1 commit intomainfrom
pbd/relax-redirected-config-warning
Jan 21, 2025
Merged

Relax the messaging when Wrangler uses redirected configuration#7832
CarmenPopoviciu merged 1 commit intomainfrom
pbd/relax-redirected-config-warning

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

Previously the messaging was rendered as a warning, which implied that the user had done something wrong. Now it is just a regular info message.

Fixes #0000


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor change that doesn't affect docs

@petebacondarwin petebacondarwin added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 20, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner January 20, 2025 19:41
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 18793b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/wrangler/src/config/config-helpers.ts Outdated
Previously the messaging was rendered as a warning, which implied that the user
had done something wrong. Now it is just a regular info message.
@petebacondarwin petebacondarwin force-pushed the pbd/relax-redirected-config-warning branch from ae6cce3 to 18793b7 Compare January 20, 2025 19:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 20, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-wrangler-7832

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7832/npm-package-wrangler-7832

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-wrangler-7832 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-workers-bindings-extension-7832 -O ./cloudflare-workers-bindings-extension.0.0.0-v41855fa70.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v41855fa70.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-create-cloudflare-7832 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-kv-asset-handler-7832

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-miniflare-7832

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-pages-shared-7832

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-unenv-preset-7832

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-vite-plugin-7832

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-vitest-pool-workers-7832

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-workers-editor-shared-7832

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-workers-shared-7832

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12874850713/npm-package-cloudflare-workflows-shared-7832

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.103.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@CarmenPopoviciu CarmenPopoviciu merged commit 97d2a1b into main Jan 21, 2025
@CarmenPopoviciu CarmenPopoviciu deleted the pbd/relax-redirected-config-warning branch January 21, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants