[vite-plugin-cloudflare] make sure that runner initialization is properly validated#7846
Conversation
🦋 Changeset detectedLatest commit: b6d547a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5de498f to
1572c8a
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-wrangler-7846You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7846/npm-package-wrangler-7846Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-wrangler-7846 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-workers-bindings-extension-7846 -O ./cloudflare-workers-bindings-extension.0.0.0-v74b239dff.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v74b239dff.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-create-cloudflare-7846 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-kv-asset-handler-7846miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-miniflare-7846@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-pages-shared-7846@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-unenv-preset-7846@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-vite-plugin-7846@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-vitest-pool-workers-7846@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-workers-editor-shared-7846@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-workers-shared-7846@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12890740728/npm-package-cloudflare-workflows-shared-7846Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
…is properly validated remove extra `JSON.stringify` call
Fixes flarelabs-net/vite-plugin-cloudflare#59
The plugin validation around the module runner initialization is not properly propagated, the changes here make sure
that it is and that a (hopefully) helpful error message is shown to the user
An easy way to see the different behavior here is to make the

createModuleRunnerfunction always throw:and run a playground application, without the changes here it's not clear/surfaced that the runner failed initialization