Skip to content

Revert "Hyperdrive dev remote fix"#7868

Merged
penalosa merged 2 commits intomainfrom
revert-7783-hyperdrive-dev-remote-fix
Jan 22, 2025
Merged

Revert "Hyperdrive dev remote fix"#7868
penalosa merged 2 commits intomainfrom
revert-7783-hyperdrive-dev-remote-fix

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Jan 22, 2025

Reverts #7783

This PR includes e2e tests that were not run before merging, and are currently failing. Example of a failing E2E test: https://github.com/cloudflare/workers-sdk/actions/runs/12912512171/job/36007511287?pr=7869#step:5:2300

@penalosa penalosa requested a review from a team as a code owner January 22, 2025 15:55
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 3dbfa27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Jan 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-wrangler-7868

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7868/npm-package-wrangler-7868

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-wrangler-7868 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-workers-bindings-extension-7868 -O ./cloudflare-workers-bindings-extension.0.0.0-va950fd4b4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va950fd4b4.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-create-cloudflare-7868 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-kv-asset-handler-7868

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-miniflare-7868

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-pages-shared-7868

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-unenv-preset-7868

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-vite-plugin-7868

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-vitest-pool-workers-7868

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-workers-editor-shared-7868

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-workers-shared-7868

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12912109536/npm-package-cloudflare-workflows-shared-7868

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.104.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 22, 2025
@penalosa penalosa merged commit 78a9a2d into main Jan 22, 2025
@penalosa penalosa deleted the revert-7783-hyperdrive-dev-remote-fix branch January 22, 2025 18:07
andyjessop added a commit that referenced this pull request Jan 23, 2025
andyjessop added a commit that referenced this pull request Jan 24, 2025
andyjessop added a commit that referenced this pull request Jan 27, 2025
* Revert "Revert "Hyperdrive dev remote fix" (#7868)"

This reverts commit 78a9a2d.

* chore: fix E2E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants