feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes by emily-shen · Pull Request #7889 · cloudflare/workers-sdk

emily-shen · 2025-01-23T22:47:01Z

Allows resource provisioning in versions upload.
Also allow switching jurisdictions (since apparently buckets with the same name can exist in different jurisdictions).

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: experimental feature

changeset-bot · 2025-01-23T22:47:05Z

🦋 Changeset detected

Latest commit: 0e311e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-23T23:07:12Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-wrangler-7889

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7889/npm-package-wrangler-7889

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-wrangler-7889 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-bindings-extension-7889 -O ./cloudflare-workers-bindings-extension.0.0.0-vd11e670fb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd11e670fb.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-create-cloudflare-7889 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-kv-asset-handler-7889

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-miniflare-7889

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-pages-shared-7889

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-unenv-preset-7889

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-vite-plugin-7889

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-vitest-pool-workers-7889

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-editor-shared-7889

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workers-shared-7889

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13032244342/npm-package-cloudflare-workflows-shared-7889

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.106.0 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20250124.0
`workerd`	1.20250124.0	1.20250124.0
`workerd --version`	1.20250124.0	2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

emily-shen · 2025-01-27T18:23:58Z

Do we care that limitCalls = true changes technically breaks existing behaviour a bit? Previously this would (slowly) get all databases, now this only gets 30.
can we pass in a larger page size (it's 10 by default) - i tested it at 100 and it didn't seem to be noticably slower.

This is a bit of a hack for now. Once the new API is ready we can switch over to that, which should be today or tomorrow

Is the new API ready yet? Do we wanna wait for it or merge this as is?

It's ready now, so I'll update this PR to use it now

edmundhung · 2025-01-28T14:01:58Z

edmundhung

Looks good to me. Just two minor comments.

edmundhung · 2025-01-28T14:05:22Z

Is the new API ready yet? Do we wanna wait for it or merge this as is?

edmundhung · 2025-01-28T14:27:53Z

Nit: Just find the syntax a little bit strange 😅

Suggested change

getFlag("RESOURCES_PROVISION")

? await provisionBindings(

bindings,

accountId,

scriptName,

props.experimentalAutoCreate,

props.config

)

: null;

if (getFlag("RESOURCES_PROVISION")) {

await provisionBindings(

bindings,

accountId,

scriptName,

props.experimentalAutoCreate,

props.config

);

}

edmundhung · 2025-01-29T12:08:46Z

+"wrangler": patch
+---
+
+feat: add resource auto-provisioning to versions upload


Should we make it clear that this is still experimental and requires an experimental flag

emily-shen requested a review from a team as a code owner January 23, 2025 22:47

workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 23, 2025

emily-shen requested a review from a team as a code owner January 24, 2025 01:14

penalosa force-pushed the emily/provisioning-versions-upload branch from 21a58b5 to 774721e Compare January 24, 2025 15:21

emily-shen commented Jan 27, 2025

View reviewed changes

emily-shen changed the title ~~feat: add provisioning to versions upload~~ feat: add provisioning to versions upload and reprovision on bucket jurisdiction changes Jan 27, 2025

edmundhung reviewed Jan 28, 2025

View reviewed changes

edmundhung approved these changes Jan 28, 2025

View reviewed changes

emily-shen and others added 10 commits January 28, 2025 18:17

add provisioning to versions upload

a7f2f8a

changeset

14df701

bucket stuff

455e48a

refactor and add tests

4b3779c

Fix snapshots

e917195

remove stray DB

15e1b1c

add more comments

c2b2a1b

correct comment

c215547

Update provision.test.ts

f4eb2e9

Use new D1 API

04f1a47

penalosa force-pushed the emily/provisioning-versions-upload branch from 87ed74f to 04f1a47 Compare January 28, 2025 18:17

lint

af76593

edmundhung reviewed Jan 29, 2025

View reviewed changes

Update neat-sloths-reply.md

0e311e4

penalosa merged commit 38db4ed into main Jan 29, 2025

penalosa deleted the emily/provisioning-versions-upload branch January 29, 2025 13:44

workers-devprod mentioned this pull request Jan 29, 2025

Version Packages #7933

Merged

-			getFlag("RESOURCES_PROVISION")
-				? await provisionBindings(
-						bindings,
-						accountId,
-						scriptName,
-						props.experimentalAutoCreate,
-						props.config
-					)
-				: null;
+			if (getFlag("RESOURCES_PROVISION")) {
+				await provisionBindings(
+					bindings,
+					accountId,
+					scriptName,
+					props.experimentalAutoCreate,
+					props.config
+				);
+			}

Conversation

emily-shen commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edmundhung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edmundhung Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emily-shen commented Jan 23, 2025 •

edited

Loading

changeset-bot Bot commented Jan 23, 2025 •

edited

Loading

github-actions Bot commented Jan 23, 2025 •

edited

Loading

edmundhung Jan 29, 2025 •

edited

Loading