Conversation
…ease date is in the future Fixes an issue where deployments would fail when there is a workerd release on the same day due to workerd releases having a date in the future because Workers does not allow using a compat date in the future.
🦋 Changeset detectedLatest commit: 9e9ff55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const date = await getWorkerdCompatibilityDate(); | ||
|
|
||
| const fallbackDate = "2023-05-18"; | ||
| const fallbackDate = "2024-11-11"; |
There was a problem hiding this comment.
Bumped the fallback date while I was here. THis was the latest date I found in https://developers.cloudflare.com/workers/configuration/compatibility-flags/ (not sure if we go off of that or workerd releases for this).
penalosa
left a comment
penalosa
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-wrangler-7891You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7891/npm-package-wrangler-7891Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-wrangler-7891 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-workers-bindings-extension-7891 -O ./cloudflare-workers-bindings-extension.0.0.0-va793b0b60.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va793b0b60.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-create-cloudflare-7891 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-kv-asset-handler-7891miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-miniflare-7891@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-pages-shared-7891@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-unenv-preset-7891@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-vite-plugin-7891@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-vitest-pool-workers-7891@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-workers-editor-shared-7891@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-workers-shared-7891@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12940600330/npm-package-cloudflare-workflows-shared-7891Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
2 participants
Fixes an issue where deployments would fail when there is a workerd release on the same day due to workerd releases having a date in the future because Workers does not allow using a compat date in the future.
I found this really frustrating that C3 templates fail to deploy if there is a workerd release on the same day:
Describe your change...