Skip to content

Provides support for run_worker_first option#7897

Merged
WillTaylorDev merged 1 commit intomainfrom
willtaylor/rename-serve-directly-run-worker-first
Jan 28, 2025
Merged

Provides support for run_worker_first option#7897
WillTaylorDev merged 1 commit intomainfrom
willtaylor/rename-serve-directly-run-worker-first

Conversation

@WillTaylorDev
Copy link
Copy Markdown
Contributor

@WillTaylorDev WillTaylorDev commented Jan 24, 2025

  • Warning for sunsetting of experimental_serve_directly
  • Error for using run_worker_first and experimental_serve_directly together
  • Sends run_worker_first field to EWC (in production) instead of old serve_directly

@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jan 24, 2025
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-run-worker-first branch from a8d90e9 to f0d7160 Compare January 24, 2025 17:15
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 74a667f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-run-worker-first branch from f0d7160 to 708e8dd Compare January 24, 2025 17:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 24, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-wrangler-7897

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7897/npm-package-wrangler-7897

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-wrangler-7897 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-workers-bindings-extension-7897 -O ./cloudflare-workers-bindings-extension.0.0.0-v8734ffd5e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8734ffd5e.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-create-cloudflare-7897 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-kv-asset-handler-7897

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-miniflare-7897

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-pages-shared-7897

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-unenv-preset-7897

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-vite-plugin-7897

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-vitest-pool-workers-7897

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-workers-editor-shared-7897

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-workers-shared-7897

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12998087073/npm-package-cloudflare-workflows-shared-7897

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.105.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-run-worker-first branch 2 times, most recently from 4ce2530 to 4013827 Compare January 24, 2025 21:31
@WillTaylorDev WillTaylorDev marked this pull request as ready for review January 24, 2025 22:26
@WillTaylorDev WillTaylorDev requested review from a team as code owners January 24, 2025 22:26
Comment thread .changeset/cuddly-wombats-decide.md Outdated
Comment thread packages/wrangler/src/__tests__/deploy.test.ts Outdated
Copy link
Copy Markdown
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things, otherwsie LGTM

Comment thread .changeset/cuddly-wombats-decide.md Outdated
Comment thread packages/wrangler/src/config/validation.ts Outdated
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-run-worker-first branch 3 times, most recently from f43c9a2 to 352ddb4 Compare January 27, 2025 20:18
- Warning for sunsetting of experimental_serve_directly
- Error for using run_worker_first and experimental_serve_directly together
- Sends run_worker_first field to EWC (in production) instead of old `serve_directly`
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/rename-serve-directly-run-worker-first branch from 352ddb4 to 74a667f Compare January 27, 2025 20:51
@WillTaylorDev WillTaylorDev merged commit 34f9797 into main Jan 28, 2025
@WillTaylorDev WillTaylorDev deleted the willtaylor/rename-serve-directly-run-worker-first branch January 28, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants