Skip to content

Use fetchPagedListResult when listing Hyperdrive configs from API#8012

Merged
mtlemilio merged 1 commit intomainfrom
mtlemilio/use-fetchPagedListResult-when-getting-hyperdrive-configs
Feb 4, 2025
Merged

Use fetchPagedListResult when listing Hyperdrive configs from API#8012
mtlemilio merged 1 commit intomainfrom
mtlemilio/use-fetchPagedListResult-when-getting-hyperdrive-configs

Conversation

@mtlemilio
Copy link
Copy Markdown
Contributor

@mtlemilio mtlemilio commented Feb 3, 2025

Fixes SQC-394

This solved an issue for customers that have more than 20 Hyperdrive configs. The Hyperdrive backend has default settings for pagination, and in some cases this would mean that not all Hyperdrive configs would be listed by the CLI.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Will be covered by existing tests.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Covered by unit tests.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Does not change the API surface of the Hyperdrive command.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: add238b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mtlemilio mtlemilio marked this pull request as ready for review February 3, 2025 17:23
@mtlemilio mtlemilio requested a review from a team as a code owner February 3, 2025 17:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-wrangler-8012

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8012/npm-package-wrangler-8012

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-wrangler-8012 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-workers-bindings-extension-8012 -O ./cloudflare-workers-bindings-extension.0.0.0-v0ca63804a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v0ca63804a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-create-cloudflare-8012 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-kv-asset-handler-8012

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-miniflare-8012

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-pages-shared-8012

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-unenv-preset-8012

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-vite-plugin-8012

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-vitest-pool-workers-8012

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-workers-editor-shared-8012

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-workers-shared-8012

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13141910470/npm-package-cloudflare-workflows-shared-8012

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.107.3 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250129.0 1.20250129.0
workerd --version 1.20250129.0 2025-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Feb 3, 2025
@mtlemilio mtlemilio force-pushed the mtlemilio/use-fetchPagedListResult-when-getting-hyperdrive-configs branch from a25a776 to ab5c997 Compare February 3, 2025 21:37
Comment thread .changeset/smooth-games-cover.md Outdated
@mtlemilio mtlemilio force-pushed the mtlemilio/use-fetchPagedListResult-when-getting-hyperdrive-configs branch from 3d1d45b to add238b Compare February 4, 2025 18:04
@mtlemilio mtlemilio merged commit c412a31 into main Feb 4, 2025
@mtlemilio mtlemilio deleted the mtlemilio/use-fetchPagedListResult-when-getting-hyperdrive-configs branch February 4, 2025 19:47
@workers-devprod workers-devprod mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

caretaking Priority for caretaking

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants