Conversation
🦋 Changeset detectedLatest commit: d4c4077 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-wrangler-8031You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8031/npm-package-wrangler-8031Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-wrangler-8031 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-workers-bindings-extension-8031 -O ./cloudflare-workers-bindings-extension.0.0.0-v29de64ea0.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v29de64ea0.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-create-cloudflare-8031 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-kv-asset-handler-8031miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-miniflare-8031@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-pages-shared-8031@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-unenv-preset-8031@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-vite-plugin-8031@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-vitest-pool-workers-8031@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-workers-editor-shared-8031@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-workers-shared-8031@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13237498627/npm-package-cloudflare-workflows-shared-8031Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
81b7b70 to
04cb321
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Very nice! 🤩 🚀
I've just left a few minor comments
|
PS: @jamesopstad there's a merge conflict with your lock file |
04cb321 to
433e70f
Compare
Thanks @dario-piotrowicz! I've addressed all the feedback. See also my comment here - #8031 (comment). |
f1b31f9 to
2c2bf54
Compare
|
@jamesopstad is there any way to make this plugin agnostic to other Vite setups? Trying to import a .wasm file in a Waku project with Cloudflare, but I can't seem to find any way to make it work. Ref: wakujs/waku#1245 |
We would love to properly support using the Cloudflare Vite plugin with Waku in the future but it's not something that will work at the moment, I'm afraid. The Wasm support is also not something that could easily be extracted into a standalone plugin at present. From the linked issue it looks like there might be a potential solution so hope that works out for the time being. |
|
Thank you! Looks like we're getting it sorted |
Fixes #7851. Partially addresses #8022.
This adds support for Wasm in the Vite plugin. Imported Wasm modules are loaded via the module fallback service in dev and included as part of the bundle in build.
I've prioritised Wasm first as users are asking for it. Once this PR is merged, however, I will create a follow up PR that generalises the approach to include
CompiledWasm,TextandDatamodules defined by the user'srules.rulesdocumentation to be added after follow up PR