Skip to content

Fix d1 info command showing read_replication: [object Object]#9161

Merged
petebacondarwin merged 2 commits intomainfrom
lambros/d1-info-fix-read-replication-mode-table
May 8, 2025
Merged

Fix d1 info command showing read_replication: [object Object]#9161
petebacondarwin merged 2 commits intomainfrom
lambros/d1-info-fix-read-replication-mode-table

Conversation

@lambrospetrou
Copy link
Copy Markdown
Contributor

@lambrospetrou lambrospetrou commented May 7, 2025

Fixes CFSQL-1287.

Fix d1 info command showing read_replication: [object Object] in the table output, and also add a fallback to unexpected fields to be JSON serialized at least.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No functionality changed.
  • Wrangler V3 Backport

@lambrospetrou lambrospetrou requested review from a team as code owners May 7, 2025 07:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2025

🦋 Changeset detected

Latest commit: 47ff243

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-wrangler-9161
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-workers-bindings-extension-9161 -O ./cloudflare-workers-bindings-extension.0.0.0-v1cd4e6c41.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1cd4e6c41.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-create-cloudflare-9161 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-kv-asset-handler-9161

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-miniflare-9161

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-pages-shared-9161

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-unenv-preset-9161

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-vite-plugin-9161

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-vitest-pool-workers-9161

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-workers-editor-shared-9161

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-workers-shared-9161

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14884390051/npm-package-cloudflare-workflows-shared-9161

Note that these links will no longer work once the GitHub Actions artifact expires.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main lambros/d1-info-fix-read-replication-mode-table might be a good starting point.

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 7, 2025
@lambrospetrou lambrospetrou added the e2e Run wrangler + vite-plugin e2e tests on a PR label May 7, 2025
lambrospetrou and others added 2 commits May 7, 2025 14:17
Also add a fallback to unexpected fields to be JSON serialized at least.
@lambrospetrou lambrospetrou force-pushed the lambros/d1-info-fix-read-replication-mode-table branch from 6ffb4e8 to 47ff243 Compare May 7, 2025 13:18
@petebacondarwin petebacondarwin merged commit 53ba97d into main May 8, 2025
17 of 18 checks passed
@petebacondarwin petebacondarwin deleted the lambros/d1-info-fix-read-replication-mode-table branch May 8, 2025 10:08
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 8, 2025
@workers-devprod workers-devprod mentioned this pull request May 8, 2025
petebacondarwin pushed a commit that referenced this pull request May 8, 2025
…bject Object] (#9166)

* Fix d1 info command showing read_replication: [object Object]

Also add a fallback to unexpected fields to be JSON serialized at least.

* Create yellow-rabbits-tap.md

* fix test in v3-maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants