CC-5462: Simplify containers images list output#9620
Merged
CarmenPopoviciu merged 2 commits intocloudflare:mainfrom Jun 25, 2025
Merged
CC-5462: Simplify containers images list output#9620CarmenPopoviciu merged 2 commits intocloudflare:mainfrom
CarmenPopoviciu merged 2 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2c7b227 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IRCody
approved these changes
Jun 16, 2025
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
66a8235 to
70d8c66
Compare
vicb
reviewed
Jun 17, 2025
Contributor
There was a problem hiding this comment.
Is this equivalent to:
Suggested change
| widths[i] = rows.map((r) => r[i].length).reduce((a, b) => Math.max(a, b), headers[i].length); | |
| widths[i] = Math.max(headers[i].length, ...rows.map((r) => r[i].length)); |
Member
Author
There was a problem hiding this comment.
Almost, but using the spread operator can fail or return incorrect results if the array is too large (according to the MDN reference). reduce doesn’t have that problem.
It’s unlikely that this array will ever be so large that that’s an issue in practice, but given that the array is technically unbounded in size I went with the safer option.
vicb
reviewed
Jun 17, 2025
d162379 to
a7bfec5
Compare
Use a simple table (one row for each entry) instead of a fancy table with badly drawn box characters. Print one row for each name:tag combination.
5ae39f0 to
9ea380e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CC-5462.
Use a simple table (one row for each entry) instead of a fancy table with box characters (that is hard to read and breaks when text wraps). Print one row for each name:tag combination.