CC-5521: Revert to "dev" when instance type is absent#9717
Merged
CarmenPopoviciu merged 7 commits intocloudflare:mainfrom Jun 25, 2025
Merged
CC-5521: Revert to "dev" when instance type is absent#9717CarmenPopoviciu merged 7 commits intocloudflare:mainfrom
CarmenPopoviciu merged 7 commits intocloudflare:mainfrom
Conversation
When the instance_type field is absent in the wrangler config and no other vcpu, memory, or disk configuration is set, automatically populate the instance_type field with "dev". This way, deleting instance_type from wrangler.jsonc reverts the deployment back to dev.
🦋 Changeset detectedLatest commit: 0dabe35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
CarmenPopoviciu
approved these changes
Jun 24, 2025
IRCody
approved these changes
Jun 24, 2025
|
Congratulations @nikitassharma, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcbs6q651025507i5ekyqx9hu This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Merged
Contributor
|
e2es ran via #9721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the instance_type field is absent in the wrangler config and no other vcpu, memory, or disk configuration is set, automatically populate the instance_type field with "dev".
This way, deleting instance_type from wrangler.jsonc reverts the deployment back to dev.
Fixes CC-5521