Skip to content

CC-5521: Revert to "dev" when instance type is absent#9717

Merged
CarmenPopoviciu merged 7 commits intocloudflare:mainfrom
nikitassharma:nsharma/dev-default
Jun 25, 2025
Merged

CC-5521: Revert to "dev" when instance type is absent#9717
CarmenPopoviciu merged 7 commits intocloudflare:mainfrom
nikitassharma:nsharma/dev-default

Conversation

@nikitassharma
Copy link
Copy Markdown
Member

When the instance_type field is absent in the wrangler config and no other vcpu, memory, or disk configuration is set, automatically populate the instance_type field with "dev".
This way, deleting instance_type from wrangler.jsonc reverts the deployment back to dev.

Fixes CC-5521


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: "dev" as default instance type is already documented
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: We don't need to backport Cloudchamber changes to v3, since it's still private beta

When the instance_type field is absent in the wrangler config and no
other vcpu, memory, or disk configuration is set, automatically populate
the instance_type field with "dev". This way, deleting instance_type
from wrangler.jsonc reverts the deployment back to dev.
@nikitassharma nikitassharma requested review from a team as code owners June 24, 2025 05:17
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 0dabe35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9717

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9717

miniflare

npm i https://pkg.pr.new/miniflare@9717

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9717

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9717

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9717

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9717

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9717

wrangler

npm i https://pkg.pr.new/wrangler@9717

commit: 32f7b98

@CarmenPopoviciu CarmenPopoviciu added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 24, 2025
Comment thread packages/wrangler/src/cloudchamber/apply.ts Outdated
Copy link
Copy Markdown
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we please get approval from the cloudchamber folks as well 🙏 ?

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 24, 2025
Comment thread packages/wrangler/src/cloudchamber/apply.ts Outdated
@CarmenPopoviciu CarmenPopoviciu added this pull request to the merge queue Jun 25, 2025
Merged via the queue into cloudflare:main with commit d2f2f72 Jun 25, 2025
33 of 34 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 25, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jun 25, 2025
@holopin-bot
Copy link
Copy Markdown

holopin-bot Bot commented Jun 25, 2025

Congratulations @nikitassharma, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcbs6q651025507i5ekyqx9hu

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@CarmenPopoviciu
Copy link
Copy Markdown
Contributor

e2es ran via #9721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants