Cap the number of errors and warnings for bulk KV put

[vicb]

Fixes #9498

Queueing a lot of errors/warnings can fill up all the memory and slow down the process as described in the linked issue.

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: not needed
• Wrangler V3 Backport
  • Wrangler PR: Cap the number of errors and warnings for bulk KV put #9776
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: 4af7085

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-backport-9775. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9775

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9775

miniflare

npm i https://pkg.pr.new/miniflare@9775

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9775

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9775

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9775

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9775

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9775

wrangler

npm i https://pkg.pr.new/wrangler@9775

commit: 4af7085

[dario-piotrowicz]

instead of using this maxNumberOfErrorsReached flag, have you considered just breaking and exiting the loop? I feel like it might make sense to just quite after the few initial errors? is there any benefit in keeping looping through all the remaining entries?

[vicb]

That's true, we could break if both maxNumberOfErrorsReached and maxNumberOfWarningsReached are reached. But it's probably not worth adding more code to optimize an error case?