SelectCell broken on IE8

[wyuenho]

Array has no indexOf on IE8

https://github.com/wyuenho/backgrid/blob/master/src/cell.js#L804

This._renderOptions has wrong context, (but somehow works on every other browser WTFFFF?)

https://github.com/wyuenho/backgrid/blob/master/src/cell.js#L848

[jgornick]

@wyuenho I found another place that needed to replace Array#indexOf usage. How would you like to merge in the commit?

[wyuenho]

Oh haha damn it. Just file PR here.

[jgornick]

@wyuenho There are some other areas in the code (row.js, body.js) that reference potential Array#indexOf. For example, https://github.com/wyuenho/backgrid/blob/master/src/body.js#L330 uses indexOf, however, there's a possibility the columns could be an Array.

[wyuenho]

Columns will always be a collection as soon as it goes thru the constructor. I've just tested it on IE 8. Everything works but the tests fail because I was using some ES5 stuff in the tests. IE8's innerHTML is also giving me a headache in the tests.

Be warned: 0.4 will drop IE 8 support. Get your polyfills out before it's too late.

Sent from my iPhone

On 17 Jan, 2014, at 11:19 pm, Joe Gornick notifications@github.com wrote:

@wyuenho There are some other areas in the code (row.js, body.js) that reference potential Array#indexOf. For example, https://github.com/wyuenho/backgrid/blob/master/src/body.js#L330 uses indexOf, however, there's a possibility the columns could be an Array.

—
Reply to this email directly or view it on GitHub.

[jgornick]

Cool. I'm 👍 for removing IE8 support.

[wyuenho]

0.3.4 has just been released with this bug fix BTW