Skip to content

Conversation

@Volatus
Copy link
Contributor

@Volatus Volatus commented May 9, 2025

Currently, the CF LB and the Isolation Segments LBs are Classic Load Balancers, which only support IPv4. To add dualstack support for Ingress, we need to create NLBs instead.

This PR adds a new LB type, nlb which create all the appropriate resources. There are no changes to concourse or cf lb types, these work as before.

It also makes the further changes to OPs Generator to create an entry per for IPv4 and IPv6 when dualstack is enabled.

Volatus added 2 commits May 13, 2025 10:53
* Adds NLB variants of existing classic load balancers
* Adds dualstack support on the NLBs
* CF TCP LB is now limited to 50 ports, instead of 100

Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
@Volatus Volatus force-pushed the feat/aws-ipv6-nlbs branch from b787fbc to c2e49a7 Compare May 13, 2025 07:53
@beyhan beyhan requested review from a team, ramonskie and selzoc and removed request for a team May 22, 2025 14:55
@beyhan beyhan moved this from Inbox to Pending Review | Discussion in Foundational Infrastructure Working Group May 22, 2025
Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable since this is optional for consumers of bbl

Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
if you would fix the linting errors we can merge it

@Volatus Volatus force-pushed the feat/aws-ipv6-nlbs branch from 34b3f78 to 0405749 Compare June 2, 2025 07:30
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
@Volatus Volatus force-pushed the feat/aws-ipv6-nlbs branch from 0405749 to 546515e Compare June 2, 2025 07:58
@aramprice
Copy link
Member

@Volatus - could you please take a look at the unit test failures?

@aramprice aramprice moved this from Pending Review | Discussion to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Jun 5, 2025
@Volatus
Copy link
Contributor Author

Volatus commented Jun 5, 2025

@aramprice yeah I'm trying to fix them

@beyhan
Copy link
Member

beyhan commented Jun 12, 2025

Waiting for the unit tests to be fixed

@peanball
Copy link
Contributor

Sorry for the delay with the unit tests. They're fixed now.
@beyhan @ramonskie @aramprice

@peanball peanball force-pushed the feat/aws-ipv6-nlbs branch from 2392355 to b088c06 Compare June 25, 2025 15:07
@beyhan beyhan merged commit 6eeec89 into cloudfoundry:main Jun 26, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Done in Foundational Infrastructure Working Group Jun 26, 2025
@Volatus Volatus deleted the feat/aws-ipv6-nlbs branch August 14, 2025 11:11
@beyhan
Copy link
Member

beyhan commented Oct 29, 2025

This introduced an issue which is currently discussed in https://cloudfoundry.slack.com/archives/C02HPPYQ2/p1761644101803199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants