-
Notifications
You must be signed in to change notification settings - Fork 182
feat: Add IPv6 Compatible NLBs for AWS #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IPv6 Compatible NLBs for AWS #644
Conversation
* Adds NLB variants of existing classic load balancers * Adds dualstack support on the NLBs * CF TCP LB is now limited to 50 ports, instead of 100 Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
b787fbc to
c2e49a7
Compare
aramprice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable since this is optional for consumers of bbl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if you would fix the linting errors we can merge it
34b3f78 to
0405749
Compare
Signed-off-by: Ismayil Mirzali <ismayil.mirzali@sap.com>
0405749 to
546515e
Compare
|
@Volatus - could you please take a look at the unit test failures? |
|
@aramprice yeah I'm trying to fix them |
|
Waiting for the unit tests to be fixed |
|
Sorry for the delay with the unit tests. They're fixed now. |
2392355 to
b088c06
Compare
|
This introduced an issue which is currently discussed in https://cloudfoundry.slack.com/archives/C02HPPYQ2/p1761644101803199. |
Currently, the CF LB and the Isolation Segments LBs are Classic Load Balancers, which only support IPv4. To add dualstack support for Ingress, we need to create NLBs instead.
This PR adds a new LB type,
nlbwhich create all the appropriate resources. There are no changes toconcourseorcflb types, these work as before.It also makes the further changes to OPs Generator to create an entry per for IPv4 and IPv6 when
dualstackis enabled.