Service operation updateInstance should wait until operation is complete

[scottfrederick]

In the org.cloudfoundry.operations.services.Services operations implementation, the createInstance() and deleteInstance() methods poll for the completion of the requested operation using LastOperationUtils.waitForCompletion and return only after CC reports that the operation is complete with a succeeded or failed status. The updateInstance() method does not follow this pattern of returning on completion, but returns immediately after initiating the operation.

It would be better if updateInstance() were consistent with the other service instance lifecycle methods.

[twoseat]

Hey @scottfrederick. The underlying request doesn't have an async option documented that would allow for this (compare with, say, delete). Do you believe there's an undocumented async on there?

[scottfrederick]

@twoseat The CC API for updating a service instance supports the same async behavior as create and delete.

If the request includes the parameter accepts_incomplete=true (which it always does with the operations API), then CC may respond with 202 Accepted and the service instance can be polled for completion status.