Adding v3 deployments endpoint #931
Conversation
Adding missing versions Adding missing response fields
|
✅ Hey AlbertoImpl! The commit authors and yourself have already signed the CLA. |
Albertoimpl
force-pushed
the
v3-deployments
branch
from
35301e1 to
7306327
Compare
The property was added a long time ago but it wasn't documented cloudfoundry/cloud_controller_ng#1273
Albertoimpl
force-pushed
the
v3-deployments
branch
from
7306327 to
e0197ee
Compare
twoseat
left a comment
twoseat
left a comment
There was a problem hiding this comment.
A great contribution (assuming it works)!
|
|
||
| PCF_2_2(Version.forIntegers(2, 112, 0)), | ||
|
|
||
| PCF_2_3(Version.forIntegers(2, 120, 0)), |
There was a problem hiding this comment.
We don't typically add these until they're needed
There was a problem hiding this comment.
PCF_2_4 was needed for DeploymentsTest
Should I delete the previous ones just because they are not used?
...r/src/test/java/org/cloudfoundry/reactor/client/v3/deployments/ReactorDeploymentsV3Test.java
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/Deployment.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/DeploymentsV3.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/DeploymentsV3.java
Show resolved
Hide resolved
...actor/src/main/java/org/cloudfoundry/reactor/client/v3/deployments/ReactorDeploymentsV3.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/client/v3/DeploymentsTest.java
Outdated
Show resolved
Hide resolved
twoseat
left a comment
twoseat
left a comment
There was a problem hiding this comment.
Looks good, but if you're able to merge it with the previous commit it would be helpful.
|
It actually works, I was able to do a tiny demo with updating a package with zero downtime thanks to this endpoint in PCF 2.4. Thanks! |
Cosmetic changes
This commit brings the client into line with version 2.125.0 of the Cloud Controller API.
Adding missing versions Adding missing response fields
The property was added a long time ago but it wasn't documented cloudfoundry/cloud_controller_ng#1273
Cosmetic changes
|
Merged in 9de4a51 |
3 participants
Adding missing versions
Adding missing response fields