Conversation
sethboyles
force-pushed
the
azure-bump-rebase
branch
from
96d4e8e to
64eee92
Compare
* we have to use a special branch of azure-storage-ruby for now until its merged in Co-authored-by: Seth Boyles <sboyles@pivotal.io> Co-authored-by: Tom Viehman <tviehman@pivotal.io>
…/bundler/fog-aws-3.12.0"" This reverts commit 197a975.
Authored-by: Seth Boyles <sboyles@pivotal.io>
sethboyles
force-pushed
the
azure-bump-rebase
branch
from
64eee92 to
ffc7e67
Compare
Closed
sweinstein22
approved these changes
Feb 22, 2022
Contributor
sweinstein22
left a comment
sweinstein22
left a comment
There was a problem hiding this comment.
Looks good to me, mostly making namespace adjustments and accounting for needed fixes to fog-google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains bumps to our branch of fog-azure-rm, as well as to fog-google, and reverts the revert of the fog-aws bump.
rebase of #2685
this introduces a dependency on a custom branch of azure-storage-ruby (Azure/azure-storage-ruby#212). We discussed merging this PR in for now with the back up plan of rewriting some internal fog-azure-rm code (which @tjvman and I have already spiked) in order to remove that custom branch dependency, in case our PR doesn't get merged in a timely manner