Test that shared service isntances don't result in duplicate results #3955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when a service instance is shared with two or more spaces the user can see, the left join in the fetcher can result in duplicates
5 tasks
a-b
approved these changes
Sep 6, 2024
a-b
approved these changes
Sep 7, 2024
Member
|
It would be great to merge this PR ASAP, so we have guardrail for #3954 |
philippthun
approved these changes
Sep 9, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Sep 9, 2024
Changes in cloud_controller_ng:
- Test that shared service isntances don't result in duplicate results
PR: cloudfoundry/cloud_controller_ng#3955
Author: Seth Boyles <seth.boyles@broadcom.com>
Benjamintf1
added a commit
that referenced
this pull request
Dec 12, 2025
… spaces * simular to what's been done with service instances #3955, if a route is shared to more then two spaces, it will show up many times in the result * still needs a test before it can be merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a service instance is shared with two or more spaces the user can see, the left join in the fetcher can result in duplicates
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests