This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Show LB Algorithm in RoutingTable (/routes page)
#447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows the lb algorithm of each endpoint in Gorouters /routes page. This simplifies debugging of related issues. The option to set route-specific load balancing algorithms was introduced in cloudfoundry#428.
MarcPaquette
approved these changes
Oct 22, 2024
Member
MarcPaquette
left a comment
MarcPaquette
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
load_balancing_algorithmtoEndpointJSON representation to display the LB algorithm in the/routespage. This simplifies debugging of related issues.The option to set route-specific load balancing algorithms was introduced in #428.
Backward Compatibility
Breaking Change? No
(According to the Gorouter docs, the /routes endpoint is an internal feature, so it shouldn't be a breaking change even though we're adding a JSON property.)