Capture staging logs on failure in CF API v3#121
Merged
Conversation
In CF API v3, when 'cf start' fails during staging, the buildpack staging logs are not automatically captured in stdout/stderr. This causes test failures when trying to assert against staging output, as the logs buffer only contains setup phase output (org/space creation, routes, etc.). This change updates Stage.Run() to automatically fetch recent logs using 'cf logs --recent' when staging fails, and appends them to the main logs buffer before returning the error. This makes staging failure logs available to tests transparently, without requiring workarounds in individual buildpack test suites. Benefits: - Tests can assert against staging logs in both API v2 and v3 - Eliminates need for manual 'cf logs --recent' workarounds - Consistent behavior across all buildpacks using switchblade
ramonskie
force-pushed
the
v3-stage-fail-logs
branch
from
e3bd706 to
8fb0d65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CF API v3, when 'cf start' fails during staging, the buildpack staging logs are not automatically captured in stdout/stderr. This causes test failures when trying to assert against staging output, as the logs buffer only contains setup phase output (org/space creation, routes, etc.).
This change updates Stage.Run() to automatically fetch recent logs using 'cf logs --recent' when staging fails, and appends them to the main logs buffer before returning the error. This makes staging failure logs available to tests transparently, without requiring workarounds in individual buildpack test suites.
Benefits: