Skip to content

Conversation

@tylersticka
Copy link
Member

@tylersticka tylersticka commented May 22, 2023

Overview

This is (probably) the last major new pattern for the new style of marketing landing page, the Hype Group. It arranges intro, content and visual object blocks in a stylized manner well suited for this sort of content.

Also makes a small change to Cloud Cover to constrain the z-indices of its clouds.

Screenshots

Narrow screens

Screen Shot 2023-05-22 at 09 24 49

Wide screens

Screenshot 2023-05-22 at 09-21-03 objects-hype-group--multiple

Docs

Screenshot 2023-05-22 at 09-22-12 objects-hype-group--multiple

Testing

Try out the deploy preview in the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 265ee35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit 265ee35
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/646b98f32e58570009be6d85
😎 Deploy Preview https://deploy-preview-2170--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tylersticka tylersticka marked this pull request as ready for review May 22, 2023 16:46
@tylersticka tylersticka requested a review from a team May 22, 2023 16:46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments on this file are great, thank you!

@spaceninja
Copy link
Member

Screenshot 2023-05-22 at 3 25 51 PM

The last item gets cut off on the bottom. I'm not sure if that's just an artifact of how it's rendered in Storybook or if it would happen in a real context, though.

Copy link
Member

@spaceninja spaceninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and it works as expected in browsers, with one possible bug that I left in a comment.

I'm approving on the assumption that it's not a real bug, just a Storybook artifact, but if it turns out to be real, I'm happy to re-review after you apply a fix.

@tylersticka
Copy link
Member Author

The last item gets cut off on the bottom. I'm not sure if that's just an artifact of how it's rendered in Storybook or if it would happen in a real context, though.

I believe this to be an artifact of Storybook, since these items intentionally overflow.

@tylersticka tylersticka merged commit 956ebf8 into main May 22, 2023
@tylersticka tylersticka deleted the feature/hype-group branch May 22, 2023 22:50
@github-actions github-actions bot mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants