Skip to content

Conversation

@tylersticka
Copy link
Member

@tylersticka tylersticka commented Jul 24, 2023

Overview

Adds a new color.$text-code token containing an alpha-transparent version of our base fuchsia, which increases the contrast of inline code elements inside of lighter-gray containers from 4.32 to 4.56.

Screenshots

Before After
Screenshot 2023-07-24 at 10 44 53 AM Screenshot 2023-07-24 at 10 45 27 AM
Screenshot 2023-07-24 at 10 45 05 AM Screenshot 2023-07-24 at 10 45 37 AM

Testing

  1. Open up the inline element story in "Canvas" view.
  2. Set the "Theme" dropdown to "Light Alt"
  3. Open the "Accessibility" tab in Storybook. Insure that there are no violations, especially no "Elements must have sufficient color contrast" violations.
  4. Because the color is alpha-transparent, the Accessibility test mentioned in the previous step may show one as "Incomplete." You can use a contrast checker like Pika to confirm sufficient contrast.

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: 64b0bc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit 64b0bc6
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/64beba25a7bfdb0008ae4cda
😎 Deploy Preview https://deploy-preview-2182--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tylersticka tylersticka marked this pull request as ready for review July 24, 2023 17:53
@tylersticka tylersticka requested a review from a team July 24, 2023 17:53
@tylersticka tylersticka merged commit b9b210b into main Jul 24, 2023
@tylersticka tylersticka deleted the feature/inline-code-contrast branch July 24, 2023 21:46
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline code color has too little contrast against lightest gray

3 participants