Conversation
🦋 Changeset detectedLatest commit: f3ab03d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| {% endfor %} | ||
| {% endset %} | ||
|
|
||
| <input {{ attributes }}> |
There was a problem hiding this comment.
Part of me wonders if the complexity of this component is worth it.
Would it be better to just tell component consumers to drop a specific class on a radio input? It seems like this component could become a hindrance if we needed to add an unsupported attribute or make changes in the future.
There was a problem hiding this comment.
(Not a strong preference/blocker)
There was a problem hiding this comment.
I wondered the same thing, but since this was copy/pasted from the checkbox, the thought of downgrading that component for parity made me a bit weary.
Maybe in the future we could combine the two into one simpler component?
There was a problem hiding this comment.
@Paul-Hebert I've added a comment to both the checkbox and radio templates to acknowledge this suggestion.
Paul-Hebert
left a comment
Paul-Hebert
left a comment
There was a problem hiding this comment.
LGTM! One non-blocking nit inline
2 participants
Overview
Creates a new Radio component for styling
radiotype inputs and applies those same styles to the Jetpack contact form CSS for consistency with checkboxes.Screenshots
Testing
Using the deploy preview, test in the following browsers: