[writeHead] survive if http.serverResponse.writeHead() re-defined #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently one of the libraries used in a project redefines
Collaborator
|
As mentioned in #224, I guess we could protect overwrites to |
Collaborator
|
Closing as no response, but feel free to file a new PR/issue if you can clarify per #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently one of the libraries used in my project redefines http.serverResponse's writeHead() ... you have to love those javascript frameworks. anyway, this "fix" will work regardless of whether or not writeHead() has been changed. thanks!