read content-type from response #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2016
cloudhead
reviewed
Oct 17, 2016
|
|
||
| Server.prototype.respond = function (pathname, status, _headers, files, stat, req, res, finish) { | ||
| var contentType = _headers['Content-Type'] || | ||
| var contentType = res.getHeader('Content-Type') || |
Owner
There was a problem hiding this comment.
Shouldn't we also be checking _headers?
Author
There was a problem hiding this comment.
Yeah you're right.. _headers could contain 'Content-Type' if respondGzip or respondNoGzip was called externally. But comparing _headers to res.getHeader here would cause unexpected behavior when someone tries to set headers via whichever method takes lower precedence.
Would it be better to revert line 347 to current master, but ensure internal calls to respond populate the _headers param from res._headers? There's only two at 59, and 78.
Totally understand if you want to kill this PR and look at a cleaner way to add this functionality to the API, I was just playing around with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently I don't think there's any way to set headers on a per request basis.. this patch allows headers to be set prior to calling
nodeStatic.serve.In addition, currently
Content-Typewould never be set before being read at line 347, by usingres.getHeaderyou allow this header to be explicitly set on this response outside this module.