Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Este PR ajusta a autenticação no Builder para propagar cognitoClaims também em logins via Google e custom-oauth, e otimiza a listagem de workspaces ao aplicar o acesso via Cognito diretamente na query do Prisma.
Changes:
- Injeta
cognitoClaimsno JWT do NextAuth para providers adicionais (Google e custom-oauth) via helperextractCognitoClaims. - Adiciona helper
getCognitoAccessibleWorkspaceIdspara derivar workspaces acessíveis a partir de claims. - Otimiza
listWorkspacespara buscar workspaces via uma única queryOR(membro no banco OU permitido por claims).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/builder/src/pages/api/auth/[...nextauth].ts | Extrai/injeta cognitoClaims no JWT para múltiplos providers e adiciona helper de extração. |
| apps/builder/src/features/workspace/helpers/cognitoUtils.ts | Adiciona helper para mapear claims → IDs de workspaces acessíveis (inclui caso ADMIN). |
| apps/builder/src/features/workspace/api/listWorkspaces.ts | Troca abordagem de 2 queries + filtro em memória por uma query com OR baseado em membership/claims. |
| apps/builder/src/features/auth/types/cognito.ts | Centraliza o tipo CognitoClaims para reutilização. |
MeBSilva
requested changes
Mar 25, 2026
MeBSilva
approved these changes
Mar 25, 2026
Fernandasacosta
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faz com que os claims do cognito sejam injetados também no login por custom-oauth e google.
-> Por google, o usuário sempre será ADMIN, já que apenas o domínio @cloudhumans pode entrar dessa forma.
-> Por custom-oauth (cloud hub login), o usuário recebe as permissões esperadas do token do cognito, igual ao login pelo cloudchat embedded.
-> A busca por workspaces foi otimizada para utilizar apenas uma query com multiplas condições ao invés de 2 queries com filtro posterior.