Skip to content

Conversation

@colbyfayock
Copy link
Collaborator

Description

#371 introduced subpath imports, undocumented, as a way to import helpers without the baggage of React and other dependencies.

This ended up having implications when dealing with importing Next.js components into this package's components, and was unable to find a good solution that fixed all scenarios that resolved all issues in both the Pages and App router.

Subpath modules will be re-added via #363 as a breaking change to resolve any compatibility issues.

Issue Ticket Number

Fixes #387

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Jan 2, 2024 5:43pm

@colbyfayock colbyfayock merged commit 5b4a158 into main Jan 2, 2024
@colbyfayock colbyfayock deleted the bug/387-revert-subpath branch January 2, 2024 17:44
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
# [5.17.0](v5.16.0...v5.17.0) (2024-01-02)

### Features

* Reverts Subpath Imports ([#393](#393)) ([5b4a158](5b4a158)), closes [#363](#363) [#387](#387)
@github-actions
Copy link

github-actions bot commented Jan 2, 2024

🎉 This PR is included in version 5.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@colbyfayock colbyfayock mentioned this pull request Jan 2, 2024
13 tasks
This was referenced Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Build error on 5.13.0 and newer

2 participants