Skip to content

v1.10.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pniel-cohen merged 1 commit into from
Sep 23, 2019
Merged

v1.10.0 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Helper/ProductGalleryHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Cloudinary\Cloudinary\Helper;

use Cloudinary\Cloudinary\Core\ConfigurationInterface;
use Cloudinary\Cloudinary\Model\Configuration;
use Magento\Framework\App\Helper\Context;

class ProductGalleryHelper extends \Magento\Framework\App\Helper\AbstractHelper
Expand All @@ -20,7 +19,7 @@ class ProductGalleryHelper extends \Magento\Framework\App\Helper\AbstractHelper
*/
protected $cloudinaryPGoptions;

const CASTING = [
protected $_casting = [
'themeProps_primary' => 'string',
'themeProps_onPrimary' => 'string',
'themeProps_active' => 'string',
Expand Down Expand Up @@ -69,8 +68,8 @@ public function getCloudinaryPGOptions($refresh = false, $ignoreDisabled = false
$this->cloudinaryPGoptions = $this->configuration->getProductGalleryAll();
foreach ($this->cloudinaryPGoptions as $key => $value) {
//Change casting
if (isset(self::CASTING[$key])) {
\settype($value, self::CASTING[$key]);
if (isset($this->_casting[$key])) {
\settype($value, $this->_casting[$key]);
$this->cloudinaryPGoptions[$key] = $value;
}
//Build options hierarchy
Expand Down
8 changes: 4 additions & 4 deletions Model/Observer/ProductGalleryChangeTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@

namespace Cloudinary\Cloudinary\Model\Observer;

use Cloudinary\Cloudinary\Model\Configuration;
use Cloudinary\Cloudinary\Core\ConfigurationInterface;
use Magento\Framework\Event\Observer;
use Magento\Framework\Event\ObserverInterface;

class ProductGalleryChangeTemplate implements ObserverInterface
{

/**
* @var Configuration
* @var ConfigurationInterface
*/
protected $configuration;

/**
* @param Configuration $configuration
* @param ConfigurationInterface $configuration
*/
public function __construct(
Configuration $configuration
ConfigurationInterface $configuration
) {
$this->configuration = $configuration;
}
Expand Down