Skip to content

Handled 'no_selection' image url#77

Merged
pniel-cohen merged 2 commits into
cloudinary:masterfrom
ankurvr:ankurvr-patch-no_selection
Jan 11, 2021
Merged

Handled 'no_selection' image url#77
pniel-cohen merged 2 commits into
cloudinary:masterfrom
ankurvr:ankurvr-patch-no_selection

Conversation

@ankurvr
Copy link
Copy Markdown
Contributor

@ankurvr ankurvr commented Dec 18, 2020

Handled 'no_selection' image when there are no image in product to show placeholder image from Magento 2

Fixes #78

Before:
Screen Shot 2020-12-18 at 5 02 23 PM

After:
Screen Shot 2020-12-18 at 5 02 06 PM

@pniel-cohen pniel-cohen merged commit 46860a0 into cloudinary:master Jan 11, 2021
@pniel-cohen
Copy link
Copy Markdown
Contributor

@ankurvr
Thanks for the contribution :)

@pniel-cohen
Copy link
Copy Markdown
Contributor

The change on Plugin/ImageHelper.php is causing a problem:
Notice: Undefined variable: imageBlock
Reverting.

RonenGiritCloudinary pushed a commit that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Critical issue when there are no images uploaded in product

2 participants