Fix Fallback to JQueryUI Compat activated.#95
Closed
frqnck wants to merge 1 commit into
Closed
Conversation
Fix ```Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site. Compat.js```
Author
|
This PR has being incubating here since May 2021? When will this be merged? Doing so "will drastically improve the performance" of this module on the PDPs (Product Detail Pages) of your customers... We are patching your code our end but would appreciate not having to have to do this. |
|
This PR should be merged in our next version. |
Author
|
I can see you have now merged this although you seems to have close this PR and added the change manually so we did not notice the addition until now. We will upgrade accordingly. Thanks you. |
|
Hi @frqnck , I thought I have sent you a notification about the fixed version. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This short PR fixes:
Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site. Compat.jsjquery/uiis deprecated since Magento 2.3 and has been split into dedicated modules to improve performance.