feat(cloudnative-pg): clusterrole aggregated to user facing roles #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouve
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
Collaborator
|
Can you remove the bump to the version? Otherwise looks good to me, thanks for switching to false by default 🙏 |
phisco
approved these changes
Jun 5, 2023
Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
itay-grudev
changed the title
itay-grudev
added
the
chart( operator )
Collaborator
|
Is this still relevant or should we close it? |
Author
|
forgot about this one, it was implemented by #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create rbac to view/edit cnpg crds and aggregate to user facing roles
view/edit/admin clusterroles are bound to a user & namespace, to manage said namespace, and now allow to create a cluster/backup/etc with this change.