Skip to content

feat: enable configuration of full_page_writes#5516

Merged
gbartolini merged 8 commits intocloudnative-pg:mainfrom
zekiyeaydemir:configurable-fullpagewrites
Sep 27, 2024
Merged

feat: enable configuration of full_page_writes#5516
gbartolini merged 8 commits intocloudnative-pg:mainfrom
zekiyeaydemir:configurable-fullpagewrites

Conversation

@zekiyeaydemir
Copy link
Contributor

@zekiyeaydemir zekiyeaydemir commented Sep 16, 2024

This patch enables users to customize the full_page_writes GUC in PostgreSQL.
By default, it is set to on as per PostgreSQL recommendation.

Closes #5506

@zekiyeaydemir zekiyeaydemir requested a review from a team as a code owner September 16, 2024 12:22
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Sep 16, 2024
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@sxd
Copy link
Member

sxd commented Sep 17, 2024

Hello @zekiyeaydemir !

You have missing the documentation about this, can you make those changes please?

Regards!

"17rc1",
"17rc1-5"
"17rc1-3"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zekiyeaydemir this change shouldn't be here, is downgrading a pg version =)

@leonardoce leonardoce force-pushed the configurable-fullpagewrites branch from b8a8d5c to c879b87 Compare September 19, 2024 13:23
github-actions bot and others added 4 commits September 19, 2024 10:01
Update the Postgres versions used in E2E tests

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: postgres-versions-updater <postgres-versions-updater@users.noreply.github.com>
Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
…e-pg#5489)"

This reverts commit 037da6f.

Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
@zekiyeaydemir zekiyeaydemir force-pushed the configurable-fullpagewrites branch from c879b87 to 0259ab0 Compare September 19, 2024 14:09
@gbartolini gbartolini changed the title Convert fixed full_page_writes parameter to configurable parameter feat: enable configuration of full_page_writes Sep 27, 2024
@gbartolini gbartolini merged commit 4e37e23 into cloudnative-pg:main Sep 27, 2024
cnpg-bot pushed a commit that referenced this pull request Sep 27, 2024
This patch enables users to customize the `full_page_writes` GUC in
PostgreSQL.

It is set to `on` by default as per PostgreSQL recommendation.

Closes #5506

Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 4e37e23)
cnpg-bot pushed a commit that referenced this pull request Sep 27, 2024
This patch enables users to customize the `full_page_writes` GUC in
PostgreSQL.

It is set to `on` by default as per PostgreSQL recommendation.

Closes #5506

Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 4e37e23)
cnpg-bot pushed a commit that referenced this pull request Sep 27, 2024
This patch enables users to customize the `full_page_writes` GUC in
PostgreSQL.

It is set to `on` by default as per PostgreSQL recommendation.

Closes #5506

Signed-off-by: zekiyeaydemir <aydemirzekiye@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Co-authored-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 4e37e23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: make full_page_writes a configurable parmeters (currently it's fixed)

5 participants