Skip to content

chore(security): improve Snyk scan#6059

Merged
fcanovai merged 1 commit intomainfrom
dev/improve_snyk
Nov 13, 2024
Merged

chore(security): improve Snyk scan#6059
fcanovai merged 1 commit intomainfrom
dev/improve_snyk

Conversation

@sxd
Copy link
Member

@sxd sxd commented Nov 11, 2024 •
edited
Loading

Until now we were running only the test command from the snyk CLI, but there's another command we should be using code test for static analysis.

Closes #6058

@sxd sxd requested review from a team, NiccoloFei, jsilvela and litaocdl as code owners November 11, 2024 09:51
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Nov 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-advanced-security
Copy link

github-advanced-security bot commented Nov 11, 2024

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sxd sxd force-pushed the dev/improve_snyk branch from e25b1a3 to d160cef Compare November 12, 2024 15:07
@sxd
Copy link
Member Author

sxd commented Nov 12, 2024

/ok-to-merge snyk workflow improvement

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Nov 12, 2024
@sxd sxd force-pushed the dev/improve_snyk branch from d160cef to d6580bb Compare November 13, 2024 08:37
@sxd
chore(security): improve Snyk scan
bef6414 
Until now we were running only the `test` command from the snyk CLI,
but there's another command we should be using `code test` for static
analysis.

Closes #6058

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
@sxd sxd force-pushed the dev/improve_snyk branch from d6580bb to bef6414 Compare November 13, 2024 09:21
@fcanovai fcanovai merged commit 7d9b993 into main Nov 13, 2024
@fcanovai fcanovai deleted the dev/improve_snyk branch November 13, 2024 09:28
cnpg-bot pushed a commit that referenced this pull request Nov 13, 2024
@sxd
chore(security): improve Snyk scan (#6059)
ad25df0 
Use snyk `code test` for static analysis, in addition to `test`.

Closes #6058

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 7d9b993)
cnpg-bot pushed a commit that referenced this pull request Nov 13, 2024
@sxd
chore(security): improve Snyk scan (#6059)
b38bd18 
Use snyk `code test` for static analysis, in addition to `test`.

Closes #6058

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 7d9b993)
cnpg-bot pushed a commit that referenced this pull request Nov 13, 2024
@sxd
chore(security): improve Snyk scan (#6059)
5c26071 
Use snyk `code test` for static analysis, in addition to `test`.

Closes #6058

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
(cherry picked from commit 7d9b993)
@ardentperf ardentperf mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsilvela jsilvela jsilvela approved these changes

@fcanovai fcanovai fcanovai approved these changes

@NiccoloFei NiccoloFei Awaiting requested review from NiccoloFei NiccoloFei is a code owner

@litaocdl litaocdl Awaiting requested review from litaocdl litaocdl is a code owner

Assignees

No one assigned

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged release-1.22 release-1.23 release-1.24

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Improve Snyk scan

4 participants

@sxd @jsilvela @fcanovai @cnpg-bot