Skip to content

docs: Remove deprecated Pod Security Policies from docs#6303

Merged
sxd merged 3 commits intocloudnative-pg:mainfrom
sharifmshaker:docs/remove-pod-security-policies
Feb 20, 2025
Merged

docs: Remove deprecated Pod Security Policies from docs#6303
sxd merged 3 commits intocloudnative-pg:mainfrom
sharifmshaker:docs/remove-pod-security-policies

Conversation

@sharifmshaker
Copy link
Contributor

@sharifmshaker sharifmshaker commented Dec 9, 2024 •
edited by jsilvela
Loading

Removing deprecated Pod Security Policies information from security docs.

Closes #5996

@sharifmshaker sharifmshaker requested review from a team and jsilvela as code owners December 9, 2024 22:29
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Dec 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch from 4590b54 to 71b9a79 Compare December 9, 2024 22:30
@sharifmshaker sharifmshaker mentioned this pull request Dec 9, 2024
Closed
4 tasks
@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch from 71b9a79 to ac67c71 Compare December 12, 2024 12:02
jsilvela
jsilvela approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jsilvela jsilvela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Took the chance to fix a couple of nits in the section.
One optional thought left as an inline comment.

docs/src/security.md Outdated

The operator explicitly sets the required security contexts.
The operator explicitly sets the required security contexts for all pods and
containers in the cluster. However, the
Copy link
Collaborator

@jsilvela jsilvela Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "However" here ... not sure. Configurability of the seccompProfile is not "against" the setting of the security context.

@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch from bf55d4d to 328f844 Compare December 17, 2024 14:20
sxd
sxd reviewed Dec 17, 2024
View reviewed changes
@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch 4 times, most recently from f5d7217 to da99792 Compare December 19, 2024 13:52
jsilvela
jsilvela requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jsilvela jsilvela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sharifmshaker , I had made some changes a few days ago.
You seem to have forced-pushed and eliminated them.
There were a few optional changes.
But the one I point out below is an outright grammar error and should be fixed.

docs/src/security.md Outdated
to run in a cluster.
For InfoSec reasons, every Kubernetes platform should implement them.
A [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) is a
Kubernetes way to defines privilege and access control settings for a Pod or Container.
Copy link
Collaborator

@jsilvela jsilvela Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-grammatical.

Copy link
Contributor Author

@sharifmshaker sharifmshaker Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies! Changed Kubernetes way to define...

@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch 5 times, most recently from f256ac9 to 05fe9e6 Compare December 19, 2024 15:53
@mnencia mnencia force-pushed the docs/remove-pod-security-policies branch from 05fe9e6 to ce5e328 Compare December 19, 2024 18:17
@sxd sxd removed release-1.22 release-1.23 release-1.24 backport-requested ◀️ This pull request should be backported to all supported releases labels Dec 23, 2024
@sxd
Copy link
Member

sxd commented Dec 23, 2024

This shouldn't be backported

@sharifmshaker
Copy link
Contributor Author

sharifmshaker commented Dec 23, 2024 •
edited
Loading

This shouldn't be backported

Is that just the label? It doesn't look like I have permissions to add or remove labels on this PR. Is there another way to prevent the backport?

@jsilvela jsilvela added the do not backport This PR must not be backported - it will be in the next minor release label Dec 23, 2024
@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch 2 times, most recently from 51c04ff to 5f2156b Compare December 23, 2024 16:04
@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch from 5f2156b to bc3891e Compare January 26, 2025 21:56
@jsilvela jsilvela self-requested a review January 27, 2025 10:20
sxd
sxd reviewed Jan 31, 2025
View reviewed changes
@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch 3 times, most recently from ed40732 to 84bc9a3 Compare February 3, 2025 13:43
@jsilvela
Copy link
Collaborator

jsilvela commented Feb 4, 2025

We should be at the point of wrapping this up. Are there any outstanding objections?
I don't want this to slip the next release...
@sharifmshaker please make sure Jonathan is happy with your changes.
Also, please can you make sure the lines fit in 80 columns? It's a rule of sorts for our docs.

@sharifmshaker sharifmshaker force-pushed the docs/remove-pod-security-policies branch from 84bc9a3 to 56c068c Compare February 4, 2025 13:05
@sharifmshaker sharifmshaker requested a review from sxd February 4, 2025 13:15
@jsilvela
Copy link
Collaborator

jsilvela commented Feb 5, 2025

I think this is only waiting for your comments @sxd , can you please take a look?

@mnencia mnencia force-pushed the docs/remove-pod-security-policies branch 2 times, most recently from b5c0be4 to 05d51d4 Compare February 19, 2025 17:17
@sharifmshaker @sxd
docs: Remove deprecated Pod Security Policies from docs
5d37a9d 
Signed-off-by: Sharif Shaker <sharif.shaker@enterprisedb.com>
@sharifmshaker @sxd
docs: Address review comments regarding security context constraints
e0fbb6c 
Signed-off-by: Sharif Shaker <sharif.shaker@enterprisedb.com>
@sharifmshaker @sxd
docs: Keep doc changes to within 80 lines
b43a7f5 
Signed-off-by: Sharif Shaker <sharif.shaker@enterprisedb.com>
@sxd sxd force-pushed the docs/remove-pod-security-policies branch from 05d51d4 to b43a7f5 Compare February 20, 2025 06:54
@sxd
Copy link
Member

sxd commented Feb 20, 2025

/ok-to-merge updating documentation

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Feb 20, 2025
@sxd sxd merged commit 4751eb7 into cloudnative-pg:main Feb 20, 2025
20 of 21 checks passed
@ardentperf ardentperf mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsilvela jsilvela jsilvela approved these changes

@sxd sxd sxd approved these changes

Assignees

No one assigned

Labels

do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation still reports pod security policies

4 participants

@sharifmshaker @sxd @jsilvela @cnpg-bot