fix(backup): do not check Cluster spec.backup if method is plugin#8486
Merged
fix(backup): do not check Cluster spec.backup if method is plugin#8486
spec.backup if method is plugin#8486Conversation
dosubot
bot
added
the
size:S
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
armru
force-pushed
the
dev/fix-plugin-backup
branch
from
9b41349 to
6705cbd
Compare
dosubot
bot
added
size:M
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/17326178551 |
armru
force-pushed
the
dev/fix-plugin-backup
branch
from
6705cbd to
e14f669
Compare
armru
changed the title
spec.backup if method is pluginspec.backup if method is plugin
mnencia
approved these changes
Sep 1, 2025
mnencia
force-pushed
the
dev/fix-plugin-backup
branch
from
e14f669 to
56b6318
Compare
fcanovai
approved these changes
Sep 3, 2025
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
fcanovai
force-pushed
the
dev/fix-plugin-backup
branch
from
56b6318 to
4553250
Compare
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
…#8486) This patch addresses a regression introduced by #8320 that does not affect any released version. The regression made it impossible to perform backups using a plugin, as the controller would incorrectly require and validate the `spec.backup` field even when the backup method was set to plugin. With this change, validating the `spec.backup` field is skipped when using plugin-based backups, restoring the expected behavior for plugin users. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit d1b5dfb)
THE-BRAHMA
pushed a commit
to THE-BRAHMA/cloudnative-pg
that referenced
this pull request
Oct 6, 2025
…cloudnative-pg#8486) This patch addresses a regression introduced by cloudnative-pg#8320 that does not affect any released version. The regression made it impossible to perform backups using a plugin, as the controller would incorrectly require and validate the `spec.backup` field even when the backup method was set to plugin. With this change, validating the `spec.backup` field is skipped when using plugin-based backups, restoring the expected behavior for plugin users. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
THE-BRAHMA
pushed a commit
to THE-BRAHMA/cloudnative-pg
that referenced
this pull request
Oct 30, 2025
…cloudnative-pg#8486) This patch addresses a regression introduced by cloudnative-pg#8320 that does not affect any released version. The regression made it impossible to perform backups using a plugin, as the controller would incorrectly require and validate the `spec.backup` field even when the backup method was set to plugin. With this change, validating the `spec.backup` field is skipped when using plugin-based backups, restoring the expected behavior for plugin users. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses a regression introduced by #8320 that does not affect any released version.
The regression made it impossible to perform backups using a plugin, as the controller would incorrectly require and validate the
spec.backupfield even when the backup method was set to plugin. With this change, validating thespec.backupfield is skipped when using plugin-based backups, restoring the expected behavior for plugin users.