fix: logic to retrieve ObjectStore from cache#429
Merged
leonardoce merged 1 commit intomainfrom Jul 2, 2025
Merged
Conversation
mnencia
force-pushed
the
dev/fix
branch
2 times, most recently
from
6aadb72 to
9c5c6ff
Compare
mnencia
approved these changes
Jul 1, 2025
There was mistake on the object used to compare the ObjectStore, we were using a type Secret instead of ObjectStore. Also, make it more clear the logic to retrieve the cached objects by getting the cached objects when are cached. Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
leonardoce
approved these changes
Jul 2, 2025
ermakov-oleg
added a commit
to ermakov-oleg/cnpg-plugin-pgbackrest
that referenced
this pull request
Feb 13, 2026
Port of upstream PRs cloudnative-pg#508 and cloudnative-pg#429. Fixes 4 bugs in ExtendedClient cache: - isObjectCached() now correctly checks for *pgbackrestv1.Archive - GVK comparison replaced with reflect.TypeOf() to handle empty TypeMeta - removeObject() condition fixed (was != instead of ==) - TTL now properly initialized with DefaultTTLSeconds
This was referenced Feb 13, 2026
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Apr 14, 2026
…rman-cloud (0.5.0 → 0.6.0) (#164) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/cloudnative-pg/charts/plugin-barman-cloud](https://cloudnative-pg.io) ([source](https://github.com/cloudnative-pg/plugin-barman-cloud)) | minor | `0.5.0` → `0.6.0` | --- ### Release Notes <details> <summary>cloudnative-pg/plugin-barman-cloud (ghcr.io/cloudnative-pg/charts/plugin-barman-cloud)</summary> ### [`v0.6.0`](https://github.com/cloudnative-pg/plugin-barman-cloud/blob/HEAD/CHANGELOG.md#060-2025-08-21) [Compare Source](cloudnative-pg/plugin-barman-cloud@v0.5.0...v0.6.0) ##### Features - Add upstream backup and recovery metrics ([#​459](cloudnative-pg/plugin-barman-cloud#459)) ([33172b6](cloudnative-pg/plugin-barman-cloud@33172b6)) - Last failed backup status field and metric ([#​467](cloudnative-pg/plugin-barman-cloud#467)) ([551a3cd](cloudnative-pg/plugin-barman-cloud@551a3cd)) ##### Bug Fixes - Add cluster/finalizers update permission ([#​465](cloudnative-pg/plugin-barman-cloud#465)) ([e0c8b64](cloudnative-pg/plugin-barman-cloud@e0c8b64)) - Check for empty WAL archive during WAL archiving ([#​458](cloudnative-pg/plugin-barman-cloud#458)) ([950364b](cloudnative-pg/plugin-barman-cloud@950364b)), closes [#​457](cloudnative-pg/plugin-barman-cloud#457) - **ci:** Show test output on failures ([#​461](cloudnative-pg/plugin-barman-cloud#461)) ([3a77079](cloudnative-pg/plugin-barman-cloud@3a77079)) - **deps:** Lock file maintenance documentation dependencies ([#​379](cloudnative-pg/plugin-barman-cloud#379)) ([a0327ea](cloudnative-pg/plugin-barman-cloud@a0327ea)) - **deps:** Lock file maintenance documentation dependencies ([#​399](cloudnative-pg/plugin-barman-cloud#399)) ([7146c51](cloudnative-pg/plugin-barman-cloud@7146c51)) - **deps:** Lock file maintenance documentation dependencies ([#​407](cloudnative-pg/plugin-barman-cloud#407)) ([4d323c2](cloudnative-pg/plugin-barman-cloud@4d323c2)) - **deps:** Lock file maintenance documentation dependencies ([#​412](cloudnative-pg/plugin-barman-cloud#412)) ([7aaebb3](cloudnative-pg/plugin-barman-cloud@7aaebb3)) - **deps:** Lock file maintenance documentation dependencies ([#​492](cloudnative-pg/plugin-barman-cloud#492)) ([4ab42c4](cloudnative-pg/plugin-barman-cloud@4ab42c4)) - **deps:** Update all non-major go dependencies ([#​435](cloudnative-pg/plugin-barman-cloud#435)) ([6028011](cloudnative-pg/plugin-barman-cloud@6028011)) - **deps:** Update all non-major go dependencies ([#​469](cloudnative-pg/plugin-barman-cloud#469)) ([a7bde51](cloudnative-pg/plugin-barman-cloud@a7bde51)) - **deps:** Update k8s.io/utils digest to [`0af2bda`](cloudnative-pg/plugin-barman-cloud@0af2bda) ([#​487](cloudnative-pg/plugin-barman-cloud#487)) ([83ada2b](cloudnative-pg/plugin-barman-cloud@83ada2b)) - **deps:** Update k8s.io/utils digest to [`4c0f3b2`](cloudnative-pg/plugin-barman-cloud@4c0f3b2) ([#​392](cloudnative-pg/plugin-barman-cloud#392)) ([e58973c](cloudnative-pg/plugin-barman-cloud@e58973c)) - **deps:** Update kubernetes packages to v0.33.2 ([#​410](cloudnative-pg/plugin-barman-cloud#410)) ([e598fb3](cloudnative-pg/plugin-barman-cloud@e598fb3)) - **deps:** Update kubernetes packages to v0.33.3 ([#​450](cloudnative-pg/plugin-barman-cloud#450)) ([32a5539](cloudnative-pg/plugin-barman-cloud@32a5539)) - **deps:** Update kubernetes packages to v0.33.4 ([#​481](cloudnative-pg/plugin-barman-cloud#481)) ([423cd5f](cloudnative-pg/plugin-barman-cloud@423cd5f)) - **deps:** Update module github.com/cert-manager/cert-manager to v1.18.1 ([#​401](cloudnative-pg/plugin-barman-cloud#401)) ([0769a28](cloudnative-pg/plugin-barman-cloud@0769a28)) - **deps:** Update module github.com/cloudnative-pg/api to v1.26.0 ([#​440](cloudnative-pg/plugin-barman-cloud#440)) ([68dfd0e](cloudnative-pg/plugin-barman-cloud@68dfd0e)) - **deps:** Update module github.com/cloudnative-pg/cnpg-i-machinery to v0.4.0 ([#​439](cloudnative-pg/plugin-barman-cloud#439)) ([e98facc](cloudnative-pg/plugin-barman-cloud@e98facc)) - **deps:** Update module github.com/onsi/ginkgo/v2 to v2.25.0 ([#​489](cloudnative-pg/plugin-barman-cloud#489)) ([5b67c11](cloudnative-pg/plugin-barman-cloud@5b67c11)) - **deps:** Update module google.golang.org/grpc to v1.73.0 ([#​394](cloudnative-pg/plugin-barman-cloud#394)) ([1365906](cloudnative-pg/plugin-barman-cloud@1365906)) - **deps:** Update module google.golang.org/grpc to v1.75.0 ([#​484](cloudnative-pg/plugin-barman-cloud#484)) ([86496ac](cloudnative-pg/plugin-barman-cloud@86496ac)) - **deps:** Update module sigs.k8s.io/kustomize/api to v0.20.0 ([#​431](cloudnative-pg/plugin-barman-cloud#431)) ([d0013df](cloudnative-pg/plugin-barman-cloud@d0013df)) - **deps:** Update module sigs.k8s.io/kustomize/api to v0.20.1 ([#​471](cloudnative-pg/plugin-barman-cloud#471)) ([fa20c09](cloudnative-pg/plugin-barman-cloud@fa20c09)) - **images:** Use bookworm for sidecar image ([#​476](cloudnative-pg/plugin-barman-cloud#476)) ([b264582](cloudnative-pg/plugin-barman-cloud@b264582)) - Logic to retrieve ObjectStore from cache ([#​429](cloudnative-pg/plugin-barman-cloud#429)) ([2a75d40](cloudnative-pg/plugin-barman-cloud@2a75d40)) - **unit-tests:** Metrics collect length ([#​475](cloudnative-pg/plugin-barman-cloud#475)) ([e40ba70](cloudnative-pg/plugin-barman-cloud@e40ba70)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/164 Co-authored-by: bot-owl <bot@erwanleboucher.dev> Co-committed-by: bot-owl <bot@erwanleboucher.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was mistake on the object used to compare the ObjectStore, we were using a type Secret instead of ObjectStore.
Also, make it more clear the logic to retrieve the cached objects by getting the cached objects when are cached.