Skip to content

compat: Import Pickler from "pickle" instead of "_pickle" #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogrisel merged 1 commit into from
May 24, 2022
Merged

compat: Import Pickler from "pickle" instead of "_pickle" #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudpickle/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
from pickle import _Pickler as Pickler # noqa: F401
else:
import pickle # noqa: F401
from _pickle import Pickler # noqa: F401
from pickle import Pickler # noqa: F401
Copy link
Contributor

@ogrisel ogrisel May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change on the other hand should be fine: on recent Python versions from pickle import Pickler imports the fast C implementation from the _pickle builtin module (when available) and falls back to the C variant if Python was not built with this module.