Open
Conversation
nitrocode
reviewed
May 4, 2022
| await exec.exec('git', ['checkout', 'HEAD', '-B', branch]); | ||
|
|
||
| await exec.exec('git', ['commit', '-am', git_commit_message]); | ||
|
|
nitrocode
reviewed
May 4, 2022
|
|
||
| await exec.exec('git', ['commit', '-am', git_commit_message]); | ||
|
|
||
|
|
nitrocode
reviewed
May 4, 2022
| } | ||
| } | ||
|
|
||
nitrocode
reviewed
May 4, 2022
| } | ||
| } else { | ||
| core.setOutput('committed', ''); | ||
| } |
Member
There was a problem hiding this comment.
You can remove those else blocks and reduce the 3 core.submit lines to a single one
Suggested change
| } | |
| } | |
| core.setOutput('committed', sha); |
Member
There was a problem hiding this comment.
You would have to set let sha = '' earlier before line 84
Member
|
How does outputting the commit allow stopping following steps? |
Author
|
@nitrocode I just fail the build if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows stopping following steps if pre-commit found an issue that was auto-fixed.